Plume/Plume

Fork 24

Remove Canapi #540

Sloučený

elegaanz sloučil 4 commity z větve bye-canapi do větve master před 2019-04-28 21:17:22 +00:00

elegaanz okomentoval/a

2019-04-21 08:49:10 +00:00

(Migrováno z github.com)

It added more complexity than it helped.

I will eventually rewrite it as a proc-macro that generates types for an API from an OpenAPI spec, so maybe it will be re-introduced at some point (but it will be totally different).

Also I added an endpoint to delete posts, the function was here before, but not exposed.

It added more complexity than it helped. I will eventually rewrite it as a proc-macro that generates types for an API from an OpenAPI spec, so maybe it will be re-introduced at some point (but it will be totally different). Also I added an endpoint to delete posts, the function was here before, but not exposed.

codecov[bot] okomentoval/a

2019-04-21 08:59:51 +00:00

(Migrováno z github.com)

Codecov Report

Merging #540 into master will increase coverage by 0.3%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #540     +/-   ##
=========================================
+ Coverage   43.97%   44.28%   +0.3%     
=========================================
  Files          68       68             
  Lines        7890     7835     -55     
=========================================
  Hits         3470     3470             
+ Misses       4420     4365     -55

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/540?src=pr&el=h1) Report > Merging [#540](https://codecov.io/gh/Plume-org/Plume/pull/540?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a20d2df50aaf39ab7e40a76c074449fac44be617?src=pr&el=desc) will **increase** coverage by `0.3%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #540 +/- ## ========================================= + Coverage 43.97% 44.28% +0.3% ========================================= Files 68 68 Lines 7890 7835 -55 ========================================= Hits 3470 3470 + Misses 4420 4365 -55 ```

trinity-1686a posoudil/a 2019-04-28 16:34:43 +00:00

trinity-1686a zanechal komentář

Vlastník

small comment but not a real problem as it was already that way before

plume-api/src/posts.rs

trinity-1686a okomentoval/a

2019-04-28 16:26:26 +00:00

Vlastník

I think it should be chosen automatically only if the user has only one blog, so to be clearly deterministic (currently it's choosing the first found, which was already the old behavior)

trinity-1686a posoudil/a 2019-04-28 17:23:59 +00:00

trinity-1686a zanechal komentář

Vlastník

👍

:+1:

trinity-1686a schválil/a tyto změny 2019-04-28 17:51:41 +00:00

trinity-1686a zanechal komentář

Vlastník

👍

:+1:

Přihlaste se pro zapojení do konverzace.

Žádní posuzovatelé

Žádný milník

Žádný projekt

Žádní přiřazení uživatelé

2 účastníků

Oznámení

Termín dokončení

Termín dokončení není platný nebo je mimo rozsah. Použijte prosím formát „rrrr-mm-dd“.

Žádný termín dokončení.

Závislosti

Nejsou nastaveny žádné závislosti.

Reference: Plume/Plume#540

K dispozici není žádný popis.

Řádky
Sloupce