Plume/Plume
9
18
Forkkaa 24
Koodi Ongelmat 177 Vetopyynnöt 8 Julkaisut 8 Wiki Toiminta

Make comments in styleshhets a bit clearer #545

Yhdistetty
marek-lach yhdistetty 2 committia lähteestä Plume-color-scheme kohteeseen master 2019-04-24 16:22:38 +00:00
Keskustelu 1 Commitit 2 Muuttuneet tiedostot 2 +3 -3
marek-lach kommentoi 2019-04-24 15:15:45 +00:00 (Migrated from github.com)
Kopioi linkki
Ei kuvausta.
codecov[bot] kommentoi 2019-04-24 15:23:03 +00:00 (Migrated from github.com)
Kopioi linkki

Codecov Report

Merging #545 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files          68       68           
  Lines        7890     7890           
=======================================
  Hits         3470     3470           
  Misses       4420     4420
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/545?src=pr&el=h1) Report > Merging [#545](https://codecov.io/gh/Plume-org/Plume/pull/545?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a20d2df50aaf39ab7e40a76c074449fac44be617?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #545 +/- ## ======================================= Coverage 43.97% 43.97% ======================================= Files 68 68 Lines 7890 7890 ======================================= Hits 3470 3470 Misses 4420 4420 ```
igalic (Migrated from github.com) hyväksyi nämä muutokset 2019-04-24 16:22:29 +00:00
igalic (Migrated from github.com) jätti kommentin
Kopioi linkki

👍

👍
static/css/_variables.scss
@ -1,4 +1,4 @@
// Colors
// Color Scheme
$background: #F4F4F4;
igalic (Migrated from github.com) kommentoi 2019-04-24 16:22:18 +00:00
Kopioi linkki

how did this change, in its own, fail the build?

how did this change, in its own, fail the build?
trinity-1686a reviewed 2019-04-24 21:34:08 +00:00
static/css/_variables.scss
@ -1,4 +1,4 @@
// Colors
// Color Scheme
$background: #F4F4F4;
trinity-1686a kommentoi 2019-04-24 21:34:08 +00:00
Omistaja
Kopioi linkki

kcov seems to use something that is not always available in circle-ci containers, and make the job fail with a "set personality failed" or similar. When I see one, I usually restart the workflow to make things pass as they should, in this case I wasn't quick enough and you noticed before me

kcov seems to use something that is not always available in circle-ci containers, and make the job fail with a "set personality failed" or similar. When I see one, I usually restart the workflow to make things pass as they should, in this case I wasn't quick enough and you noticed before me
Kirjaudu sisään liittyäksesi keskusteluun.
Reviewers
No reviewers
igalic
Tunnisteet
Tyhjennä tunnisteet   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Ei tunnisteita
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Merkkipaalu
Tyhjennä merkkipaalu
Ei kohteita
Ei merkkipaalua
Projektit
Clear projects
Ei kohteita
Ei projektia
Käsittelijä
Tyhjennä käsittelijä
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

Määräpäivää ei ole asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Viittaus: Plume/Plume#545
Ei kuvausta.
Poista haara "Plume-color-scheme"

Haaran poistaminen on pysyvä toimenpide. Vaikka poistettu haara voi jäädä olemaan lyhyeksi ajaksi, ennen kuin todellisesti poistetaan, poistoa EI VOI perua useimmiten. Jatketaanko?