#545 Make comments in styleshhets a bit clearer

Merged
marek-lach merged 2 commits from Plume-color-scheme into master 1 year ago
marek-lach commented 1 year ago (Migrated from github.com)
There is no content yet.
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #545 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files          68       68           
  Lines        7890     7890           
=======================================
  Hits         3470     3470           
  Misses       4420     4420
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/545?src=pr&el=h1) Report > Merging [#545](https://codecov.io/gh/Plume-org/Plume/pull/545?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a20d2df50aaf39ab7e40a76c074449fac44be617?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #545 +/- ## ======================================= Coverage 43.97% 43.97% ======================================= Files 68 68 Lines 7890 7890 ======================================= Hits 3470 3470 Misses 4420 4420 ```
igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

👍

@@ -1,4 +1,4 @@
// Colors
// Color Scheme
$background: #F4F4F4;
Plume_migration_agent commented 1 year ago

how did this change, in its own, fail the build?

how did this change, in its own, fail the build?
trinity-1686a reviewed 1 year ago
@@ -1,4 +1,4 @@
// Colors
// Color Scheme
$background: #F4F4F4;
trinity-1686a commented 1 year ago

kcov seems to use something that is not always available in circle-ci containers, and make the job fail with a “set personality failed” or similar. When I see one, I usually restart the workflow to make things pass as they should, in this case I wasn’t quick enough and you noticed before me

kcov seems to use something that is not always available in circle-ci containers, and make the job fail with a "set personality failed" or similar. When I see one, I usually restart the workflow to make things pass as they should, in this case I wasn't quick enough and you noticed before me

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as ff92ac0763.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.