Restore menu.js file for iOS #550

Closed

marek-lach wants to merge 3 commits from restores-menu-js-for-ios into master

marek-lach commented

2019-04-27 10:03:16 +00:00

(Migrated from github.com)

No description provided.

codecov[bot] commented

2019-04-27 10:13:23 +00:00

(Migrated from github.com)

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files          68       68           
  Lines        7890     7890           
=======================================
  Hits         3470     3470           
  Misses       4420     4420

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/550?src=pr&el=h1) Report > Merging [#550](https://codecov.io/gh/Plume-org/Plume/pull/550?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/85aa0883c8c2ffc7a051e24d23cc942ca76cc609?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #550 +/- ## ======================================= Coverage 43.97% 43.97% ======================================= Files 68 68 Lines 7890 7890 ======================================= Hits 3470 3470 Misses 4420 4420 ```

elegaanz (Migrated from github.com) reviewed 2019-04-27 10:32:56 +00:00

elegaanz (Migrated from github.com) left a comment

I think I won't accept this PR (sorry), since this code now lives here normally: https://github.com/Plume-org/Plume/blob/master/plume-front/src/main.rs#L70

However, this will probably help us to debug the issue: could you go on https://pr-550.joinplu.me/ and check that the menu works as expected on a small screen?

Thank you (and sorry again).

I think I won't accept this PR (sorry), since this code now lives here normally: https://github.com/Plume-org/Plume/blob/master/plume-front/src/main.rs#L70 However, this will probably help us to debug the issue: could you go on https://pr-550.joinplu.me/ and check that the menu works as expected on a small screen? Thank you (and sorry again).

elegaanz commented

2019-04-27 10:34:14 +00:00

(Migrated from github.com)

Before testing, this script should be loaded, so you should probably add it to templates/base.rs.html too.

Before testing, this script should be loaded, so you should probably add it to `templates/base.rs.html` too.

marek-lach commented

2019-04-27 10:45:42 +00:00

(Migrated from github.com)

Yep, just testing. What are you even sorry about, as long as we fix this somehow, that's great progress :-)

👍 1

marek-lach commented

2019-04-27 16:12:57 +00:00

(Migrated from github.com)

Well, the best thing would be to probably compare the old and the new script for the menu, and see where a mistake occured.

Closing this for now.

Well, the best thing would be to probably compare the old and the new script for the menu, and see where a mistake occured. Closing this for now.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#550

No description provided.