Restore menu.js file for iOS #550

Closed
marek-lach wants to merge 3 commits from restores-menu-js-for-ios into master
marek-lach commented 3 years ago (Migrated from github.com)
Owner
There is no content yet.
codecov[bot] commented 3 years ago (Migrated from github.com)
Owner

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files          68       68           
  Lines        7890     7890           
=======================================
  Hits         3470     3470           
  Misses       4420     4420
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/550?src=pr&el=h1) Report > Merging [#550](https://codecov.io/gh/Plume-org/Plume/pull/550?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/85aa0883c8c2ffc7a051e24d23cc942ca76cc609?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #550 +/- ## ======================================= Coverage 43.97% 43.97% ======================================= Files 68 68 Lines 7890 7890 ======================================= Hits 3470 3470 Misses 4420 4420 ```
elegaanz (Migrated from github.com) reviewed 3 years ago
elegaanz (Migrated from github.com) left a comment

I think I won't accept this PR (sorry), since this code now lives here normally: https://github.com/Plume-org/Plume/blob/master/plume-front/src/main.rs#L70

However, this will probably help us to debug the issue: could you go on https://pr-550.joinplu.me/ and check that the menu works as expected on a small screen?

Thank you (and sorry again).

elegaanz commented 3 years ago (Migrated from github.com)
Owner

Before testing, this script should be loaded, so you should probably add it to templates/base.rs.html too.

Before testing, this script should be loaded, so you should probably add it to `templates/base.rs.html` too.
marek-lach commented 3 years ago (Migrated from github.com)
Poster
Owner

Yep, just testing. What are you even sorry about, as long as we fix this somehow, that's great progress :-)

Yep, just testing. What are you even sorry about, as long as we fix this somehow, that's great progress :-)
marek-lach commented 3 years ago (Migrated from github.com)
Poster
Owner

Well, the best thing would be to probably compare the old and the new script for the menu, and see where a mistake occured.

Closing this for now.

Well, the best thing would be to probably compare the old and the new script for the menu, and see where a mistake occured. Closing this for now.
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.