Add some feedback when performing some actions
#552
Обединени
elegaanz
обедини 7 ревизии от action-feedback
във master
преди 5 години
Reviewers
Request review
No reviewers
Етикети
Изчисти етикети
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Apply labels
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Няма етикет
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Етап
Set milestone
Изчисти етап
No items
Няма етап
Изпълнители
Assign users
Изчисти изпълнители
Няма изпълнители
2 участника
Известия
Due Date
Крайният срок е невалиден или извън обхват. Моля използвайте форматът 'гггг-мм-дд'.
No due date set.
Зависимости
No dependencies set.
Reference: Plume/Plume#552
Reference in New Issue
Все още няма съдържание.
Delete Branch 'action-feedback'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Не
Да
Here is an example of what it looks like (this is just a test, in reality you can only have one of these messages at the same time):
I don't know if there is a simpler way to do it. Also, I added
msg: Option<FlashMessage>
to almost all routes to be sure that if a message was present it would be rendered, but maybe it is not necessary and only make the code harder to read? And maybemsg
should go inPlumeRocket
as it is used almost everywhere?Fixes #468
Codecov Report
Considering how it must be everywhere, I think it can go in
PlumeRocket
, as well as in templateBaseContext
. AlsoBaseContext
could implementFrom<PlumeRocket>
so it is easier to build and reduce duplicationmaybe we should hold on committing the translations in such prs?
do then regularly elsewhere
this is supposed to be
but i just realised that fuzzy means it was auto translated…
@igalic I don't really know… it is true it pollutes a little bit the diff, but at the same time it makes sense to have them with the change in the interface.
Yes, it was auto-translated. Once it will be on Crowdin, you will be able to fix it. 😉
I'd be to not pollute pr with this, and have something that autocommit the changes once a week, or after each merge
👀
@ -17,0 +27,4 @@
&Connection,
&Catalog,
Option<User>,
Option<(String, String)>,
why not implementing
From<PlumeRocket>
for Context? It will auto implementInto<Context>
for PlumeRocket, and you should be able to useinto()
with no need to import this trait everywhere@ -17,0 +27,4 @@
&Connection,
&Catalog,
Option<User>,
Option<(String, String)>,
Because Rust is complaining about the fact that all the parameters of the trait comes from another crate, and that it could cause conflicts, while I don't think it can? 🤷♀️ But yeah, I tried it, and it doesn't work.
@ -17,0 +27,4 @@
&Connection,
&Catalog,
Option<User>,
Option<(String, String)>,
ho, it's because BaseContext is not a true struct but a typedef to a tuple of basic types (in theory it could cause conflict, because the exact same trait can be implemented in plume-model, thus creating a conflict). This mean we can either convert BaseContext to be a true type, or implement Into in plume-models. I've tried the first one, but it requires some small but ugly changes so I'm not sure it would be better (you can take a look at the patch here)
👍
Do you want me to apply your patch before merging?
It was just to show what I came up with, but having
&(&rockets).into()
everywhere is definitely worse than importing a traitReviewers
8f1ab3485e
.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Forgejo.