Deleting a branch is permanent. It CANNOT be undone. Continue?
#553 Theme update
Merged
elegaanz
merged 21 commits from theme-update into master 1 year ago
Reviewers
Labels
Milestone
No Milestone
Assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
This pull request currently doesn't have any dependencies.
Loading…
There is no content yet.
Delete Branch 'theme-update'
So far:
As I started it, this redesign is not perfectly following what was done on Figma (for instance lighter colors were not planned), but I’m open to discussion if you think Figma mockups should be better respected.
It is available at https://pr-553.joinplu.me/ if you want to see how it looks like. You can login with admin/admin123 to see all the pages.
Codecov Report
Perhaps
main article's max-width should be a bit wider?40remis quite narrow. Optimal readability would suggest making it somewhere between 45-75 characters, which can be represented by thechunit in CSS. So I would propose perhaps making the rulemax-width: 70chinstead ofmax-width: 40remAlso the
main headerandmain header > imgare way too tall, and should each have a max-height of no more thancalc(100vh - $heightOfBodyHeader)-- this allows the header to not be bigger than the browser viewport.So… I tried to limit the height of the illustration, but it is impossible to do it without losing the ratio or a part of the image. I don’t know what should be done: hide some a portion of the illustration if it is too big, or give the responsibility to author to provide images in reasonable dimensions?
Someone also proposed to have an option that could be enabled to limit the height of the header (by hiding some of the image) if you want to be sure to never have giant images. So that can be a solution too.
I think fitting is better than cropping. You can either accept the ratio loss inherent to cover-fit, or you can cap the max-width of the image/header (in addition to the max-height). That style of header image can be seen in Ghost, for example: https://demo.ghost.io/welcome/
This is a great change. I only propose changing the main purple color of links from the current hex code of
#7765E3to something like#887ADE,#8D80DE, or perhaps#9784CB, because on very light backgrounds, it’s very hard to see, as shown bellow:@marek-lach Even with another shade of purple the contrast was quite poor, so I made it white, but with underlining when you pass your cursor over it to make you understand it is a link.
Under that we could also add the line:
display: -webkit-flex;to ensure Safari likes it :-)According to this table Safari supports
display: flexeven without a specific prefix.Maybe under the
About this instancelink in the footer, there could also be aPrivacy policylink. It would help to fill up the empty space there a little bit.As per what the `Privacy policy’ page itself could contain, just basic stuff could be something like:
If you are browsing this site as a visitor, your IP address is collected by the server for moderation purposes.
As a registered user, you also have to provide your username (which does not have to be your real name), your functional email address and a password, in order to be able to log in, write articles and comment. The content you submit is stored until you delete it.
I added it. I just changed a bit your text, because we don’t actually collect IP addresses, and I added a part about which cookies we are using.
Sure 👍
In that case the line As a registered user, you also have to provide your username, doesn’t need the
alsoin it.I think this should be a default privacy policy only, and should be editable easily by admins (probably in a future pr, this one is supposed to be about design). While we don’t store much (no ip, no cookies when not logged in...), most reverse proxy configuration will log at least user ip.
this would require fixing merge conflict before validation
Watching the whole directory (first rerun-if-changed, was there before) is pretty much useless as it is platform dependent, and on our main target (linux) apply basically on file creation/deletion inside, it could be removed
what should it be changed to?
this value might be a bit too close to actual white : pages that are mainly forms (creating article, editing profile, or even logging in) look odd in my opinion. I’ve tried with
F8F8F8, and I think it looks better so to contrast withFFFFFFinside input elementsI think I introduced a variable for that value, but maybe I didn’t?
👍
(I just merged master into this to fix conflict)
Reviewers
ad3a8b92d1.