Plume
/
Plume
7
9
Fork 8
Code Issues 131 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#556 remove the new index lock tantivy uses

Merged
Plume_migration_agent merged 1 commits from tantivy-unlock into master 1 year ago
Conversation 3 Commits 1 Files Changed 1
trinity-1686a commented 1 year ago
There is no content yet.
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #556 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   44.67%   44.66%   -0.02%     
==========================================
  Files          70       70              
  Lines        7989     7991       +2     
==========================================
  Hits         3569     3569              
- Misses       4420     4422       +2
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/556?src=pr&el=h1) Report > Merging [#556](https://codecov.io/gh/Plume-org/Plume/pull/556?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/49bb8cb0bc2a5e9164b2931b1ba799b4434c68a1?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #556 +/- ## ========================================== - Coverage 44.67% 44.66% -0.02% ========================================== Files 70 70 Lines 7989 7991 +2 ========================================== Hits 3569 3569 - Misses 4420 4422 +2 ```
elegaanz (Migrated from github.com) approved these changes 1 year ago
fulmicoton commented 1 year ago (Migrated from github.com)
Owner

Sorry for chiming in a bit late. In recent version, tantivy uses bsd locks. You don’t need to remove those files at all. If your process die, restarting should work just fine.

Sorry for chiming in a bit late. In recent version, tantivy uses bsd locks. You don't need to remove those files at all. If your process die, restarting should work just fine.
trinity-1686a commented 1 year ago
Owner

I’ve noticed it while trying my changes, but actually one user managed to have it’s index locked while no plume was running, I’ve no idea how. Anyway it’s here in case it happen, and hopefully it does not

I've noticed it while trying my changes, but actually one user managed to have it's index locked while no plume was running, I've no idea how. Anyway it's here in case it happen, and hopefully it does not

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 18ae6e26b3.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 Plume_migration_agent
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'tantivy-unlock'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes