#556 remove the new index lock tantivy uses

Merged
Plume_migration_agent merged 1 commits from tantivy-unlock into master 1 year ago
There is no content yet.
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #556 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   44.67%   44.66%   -0.02%     
==========================================
  Files          70       70              
  Lines        7989     7991       +2     
==========================================
  Hits         3569     3569              
- Misses       4420     4422       +2
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/556?src=pr&el=h1) Report > Merging [#556](https://codecov.io/gh/Plume-org/Plume/pull/556?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/49bb8cb0bc2a5e9164b2931b1ba799b4434c68a1?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #556 +/- ## ========================================== - Coverage 44.67% 44.66% -0.02% ========================================== Files 70 70 Lines 7989 7991 +2 ========================================== Hits 3569 3569 - Misses 4420 4422 +2 ```
elegaanz (Migrated from github.com) approved these changes 1 year ago
fulmicoton commented 1 year ago (Migrated from github.com)
Owner

Sorry for chiming in a bit late. In recent version, tantivy uses bsd locks. You don’t need to remove those files at all. If your process die, restarting should work just fine.

Sorry for chiming in a bit late. In recent version, tantivy uses bsd locks. You don't need to remove those files at all. If your process die, restarting should work just fine.
trinity-1686a commented 1 year ago
Owner

I’ve noticed it while trying my changes, but actually one user managed to have it’s index locked while no plume was running, I’ve no idea how. Anyway it’s here in case it happen, and hopefully it does not

I've noticed it while trying my changes, but actually one user managed to have it's index locked while no plume was running, I've no idea how. Anyway it's here in case it happen, and hopefully it does not

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 18ae6e26b3.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.