Improve notification management #561
No reviewers
Labels
No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#561
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "notifications"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fix #472
fix #505
Shouln't this be
.any(...)
? Because I'm still getting duplicated notifications.Also,
AsActor::is_local
is technically broken, since it only doesinstance_id == 1
which is not always correct (even if it is most of the time (like, unless you ranplm instance new
twice, it will probably be correct)).Maybe we should have a global storing the local instance info somewhere BTW (loaded only once when the app starts)? It would probably avoid a lot of queries to the database, and would allow to fix this issue without changing
AsActor
definition (but probably in another PR if we ever do it).if all mentioned users are different from this author, send notification. I think it's correct, and when I tested it, it seemed to work.
Edit : My bad, forgot to add some file
Codecov Report
Oh, I found what is wrong I think: the mention was inserted after the comment in the database.
OK, I'm too late, you already found it.
Seems to work! Thank you! 😊