Plume/Plume

フォーク 24

use openssl instead of sha256sum for build.rs #568

マージ済み

Plume_migration_agent が 2 個のコミットを openssl から master へマージ 2019-05-10 14:15:31 +00:00

trinity-1686a がコメント

2019-05-07 08:40:47 +00:00

オーナー

fix #566

igalic (github.comから移行) がレビュー 2019-05-07 09:54:16 +00:00

igalic (github.comから移行) がコメント

👀

build.rs

igalic (github.comから移行) がコメント

2019-05-07 09:54:00 +00:00

i'd prefer we leave stat(1) out of this, as the --printf option is not platform independent, and no equivalent, platform independent option exists

the only other would be to use -c

i'd prefer we leave `stat(1)` out of this, as the `--printf` option is not platform independent, and no equivalent, platform independent option exists the only other would be to use `-c`

trinity-1686a がレビュー 2019-05-07 11:21:10 +00:00

build.rs

trinity-1686a がコメント

2019-05-07 11:21:09 +00:00

作成者

オーナー

The goal of this function is to have a unique id, and best effort is made to not invalidate cache if not necessary. We can also not make that best effort (recompiling Plume => new cache id) and just generate a random hex string. That would be platform independent.
What shall I do?

codecov[bot] がコメント

2019-05-07 11:39:00 +00:00

(github.comから移行)

Codecov Report

Merging #568 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=h1) Report > Merging [#568](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #568 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```

igalic (github.comから移行) がレビュー 2019-05-09 12:07:56 +00:00

build.rs

igalic (github.comから移行) がコメント

2019-05-09 12:07:55 +00:00

i think i'd just go with stat -c for now

there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.

i think i'd just go with `stat -c` for now there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.

igalic (github.comから移行) が変更を承認 2019-05-10 14:14:53 +00:00

igalic (github.comから移行) がコメント

tested, works!

サインインしてこの会話に参加。

レビューアなし

igalic

マイルストーンなし

プロジェクトなし

担当者なし

2 人の参加者

通知

期日

期日が正しくないか範囲を超えています。 "yyyy-mm-dd" の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#568

説明はありません。

Rows
Columns