#571 upload artifact of wasm binary

Merged
Plume_migration_agent merged 1 commits from wasm-artifact into master 1 year ago

fix #570

fix #570
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

👀

@@ -218,1 +218,4 @@
destination: plume.tar.gz
- store_artifacts:
path: wasm.tar.gz
destination: wasm.tar.gz
Plume_migration_agent commented 1 year ago

and as such, I’d just call it static.tar.gz

(should this have a version number)

and as such, I'd just call it static.tar.gz (should this have a version number)
@@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
Plume_migration_agent commented 1 year ago

this one should be with migrations/$FEATURES, and without static/

this one should be with `migrations/$FEATURES`, and without `static/`
@@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
Plume_migration_agent commented 1 year ago

This one, should contain all of static/ — it’s entirely architecture independent!

This one, should contain all of `static/` — it's entirely architecture independent!
trinity-1686a reviewed 1 year ago
@@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a commented 1 year ago

migrations don’t require to be shipped as they are integrated into plm, and I think it should be with static/ so that for x86_64 users, there is only a single archive to download, un-tgz, and run

migrations don't require to be shipped as they are integrated into `plm`, and I think it should be with `static/` so that for x86_64 users, there is only a single archive to download, un-tgz, and run
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=h1) Report > Merging [#571](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #571 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```
trinity-1686a reviewed 1 year ago
@@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a commented 1 year ago

I expected it to be an alternative step to all cargo web things in here, in which case it doesn’t require the whole static/ dir as it is git cloned. What were your expectations?

I expected it to be an alternative step to all `cargo web` things in [here](https://docs.joinplu.me/installation/with/source-code), in which case it doesn't require the whole `static/` dir as it is `git clone`d. What were your expectations?
igalic (Migrated from github.com) reviewed 1 year ago
@@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
Plume_migration_agent commented 1 year ago

you are right.

you are right.
igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

i thought about this, and come to the conclusion, that you’re right
👍

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 90f6ef0380.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.