Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 9 Releases 8 Wiki Activity

upload artifact of wasm binary #571

Merged
Plume_migration_agent merged 1 commit from wasm-artifact into master 2019-05-10 13:38:44 +00:00
Conversation 1 Commits 1 Files changed 2 +5 -1
trinity-1686a commented 2019-05-10 11:24:33 +00:00
Owner
Copy link

fix #570

fix #570
igalic (Migrated from github.com) reviewed 2019-05-10 11:36:50 +00:00
igalic (Migrated from github.com) left a comment
Copy link

👀

👀
.circleci/config.yml
@ -218,1 +218,4 @@
destination: plume.tar.gz
- store_artifacts:
path: wasm.tar.gz
destination: wasm.tar.gz
igalic (Migrated from github.com) commented 2019-05-10 11:36:42 +00:00
Copy link

and as such, I'd just call it static.tar.gz

(should this have a version number)

and as such, I'd just call it static.tar.gz (should this have a version number)
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (Migrated from github.com) commented 2019-05-10 11:34:45 +00:00
Copy link

this one should be with migrations/$FEATURES, and without static/

this one should be with `migrations/$FEATURES`, and without `static/`
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (Migrated from github.com) commented 2019-05-10 11:35:45 +00:00
Copy link

This one, should contain all of static/ — it's entirely architecture independent!

This one, should contain all of `static/` — it's entirely architecture independent!
trinity-1686a reviewed 2019-05-10 11:43:15 +00:00
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a commented 2019-05-10 11:43:15 +00:00
Author
Owner
Copy link

migrations don't require to be shipped as they are integrated into plm, and I think it should be with static/ so that for x86_64 users, there is only a single archive to download, un-tgz, and run

migrations don't require to be shipped as they are integrated into `plm`, and I think it should be with `static/` so that for x86_64 users, there is only a single archive to download, un-tgz, and run
codecov[bot] commented 2019-05-10 11:45:08 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=h1) Report > Merging [#571](https://codecov.io/gh/Plume-org/Plume/pull/571?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #571 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```
trinity-1686a reviewed 2019-05-10 11:51:56 +00:00
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
trinity-1686a commented 2019-05-10 11:51:56 +00:00
Author
Owner
Copy link

I expected it to be an alternative step to all cargo web things in here, in which case it doesn't require the whole static/ dir as it is git cloned. What were your expectations?

I expected it to be an alternative step to all `cargo web` things in [here](https://docs.joinplu.me/installation/with/source-code), in which case it doesn't require the whole `static/` dir as it is `git clone`d. What were your expectations?
igalic (Migrated from github.com) reviewed 2019-05-10 13:08:56 +00:00
script/generate_artifact.sh
@ -4,2 +4,3 @@
strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES
tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic (Migrated from github.com) commented 2019-05-10 13:08:55 +00:00
Copy link

you are right.

you are right.
igalic (Migrated from github.com) approved these changes 2019-05-10 13:09:23 +00:00
igalic (Migrated from github.com) left a comment
Copy link

i thought about this, and come to the conclusion, that you're right
👍

i thought about this, and come to the conclusion, that you're right 👍
Sign in to join this conversation.
Reviewers
No reviewers
igalic
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#571
No description provided.
Delete branch "wasm-artifact"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?