Plume/Plume
8
17
Fork 23
Code Issues 176 Pull requests 9 Releases 8 Wiki Activity

upload artifact of wasm binary #571

Merged
Plume_migration_agent merged 1 commit from wasm-artifact into master 2019-05-10 13:38:44 +00:00
Conversation 1 Commits 1 Files changed 2 +5 -1
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.circleci/config.yml
View file

@ -216,6 +216,9 @@ jobs:
- store_artifacts: - store_artifacts:
path: plume.tar.gz path: plume.tar.gz
destination: plume.tar.gz destination: plume.tar.gz
- store_artifacts:
path: wasm.tar.gz
destination: wasm.tar.gz
igalic commented 2019-05-10 11:36:42 +00:00 (Migrated from github.com)
Review
Copy link

and as such, I'd just call it static.tar.gz

(should this have a version number)

and as such, I'd just call it static.tar.gz (should this have a version number)
push translations: push translations:
executor: executor:

3
script/generate_artifact.sh
View file

@ -2,4 +2,5 @@
mkdir bin mkdir bin
cp target/release/{plume,plm} bin cp target/release/{plume,plm} bin
strip -s bin/* strip -s bin/*
tar -cvzf plume.tar.gz bin/ static/ migrations/$FEATURES tar -cvzf plume.tar.gz bin/ static/
tar -cvzf wasm.tar.gz static/plume-front.{js,wasm}
igalic commented 2019-05-10 11:34:45 +00:00 (Migrated from github.com)
Review
Copy link

this one should be with migrations/$FEATURES, and without static/

this one should be with `migrations/$FEATURES`, and without `static/`
trinity-1686a commented 2019-05-10 11:43:15 +00:00
Review
Copy link

migrations don't require to be shipped as they are integrated into plm, and I think it should be with static/ so that for x86_64 users, there is only a single archive to download, un-tgz, and run

migrations don't require to be shipped as they are integrated into `plm`, and I think it should be with `static/` so that for x86_64 users, there is only a single archive to download, un-tgz, and run