Plume
/
Plume
7
9
Fork 8
Code Issues 131 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#572 cache local instance

Merged
Plume_migration_agent merged 4 commits from cache-local-instance into master 1 year ago
Conversation 1 Commits 4 Files Changed 20
trinity-1686a commented 1 year ago

fix #564

fix #564
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #572 into master will decrease coverage by 0.2%.
The diff coverage is 36.73%.

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   34.72%   34.51%   -0.21%     
==========================================
  Files          67       67              
  Lines        7851     7872      +21     
  Branches     1886     1890       +4     
==========================================
- Hits         2726     2717       -9     
- Misses       4367     4394      +27     
- Partials      758      761       +3
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/572?src=pr&el=h1) Report > Merging [#572](https://codecov.io/gh/Plume-org/Plume/pull/572?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/90f6ef0380fb3209a3c68963ba32cf85bdd72112?src=pr&el=desc) will **decrease** coverage by `0.2%`. > The diff coverage is `36.73%`. ```diff @@ Coverage Diff @@ ## master #572 +/- ## ========================================== - Coverage 34.72% 34.51% -0.21% ========================================== Files 67 67 Lines 7851 7872 +21 Branches 1886 1890 +4 ========================================== - Hits 2726 2717 -9 - Misses 4367 4394 +27 - Partials 758 761 +3 ```
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Nice! Thank you.

elegaanz (Migrated from github.com) reviewed 1 year ago
plume-cli/src/main.rs
Plume_migration_agent commented 1 year ago

Do you really need this let here?

Do you really need this `let` here?
trinity-1686a reviewed 1 year ago
plume-cli/src/main.rs
trinity-1686a commented 1 year ago

just to explicitly ignore a warning about unused result

just to explicitly ignore a warning about unused result

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 773fbfe7c8.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 Plume_migration_agent
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'cache-local-instance'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes