#572 cache local instance

Merged
Plume_migration_agent merged 4 commits from cache-local-instance into master 1 year ago

fix #564

fix #564
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #572 into master will decrease coverage by 0.2%.
The diff coverage is 36.73%.

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   34.72%   34.51%   -0.21%     
==========================================
  Files          67       67              
  Lines        7851     7872      +21     
  Branches     1886     1890       +4     
==========================================
- Hits         2726     2717       -9     
- Misses       4367     4394      +27     
- Partials      758      761       +3
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/572?src=pr&el=h1) Report > Merging [#572](https://codecov.io/gh/Plume-org/Plume/pull/572?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/90f6ef0380fb3209a3c68963ba32cf85bdd72112?src=pr&el=desc) will **decrease** coverage by `0.2%`. > The diff coverage is `36.73%`. ```diff @@ Coverage Diff @@ ## master #572 +/- ## ========================================== - Coverage 34.72% 34.51% -0.21% ========================================== Files 67 67 Lines 7851 7872 +21 Branches 1886 1890 +4 ========================================== - Hits 2726 2717 -9 - Misses 4367 4394 +27 - Partials 758 761 +3 ```
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Nice! Thank you.

elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Do you really need this let here?

Do you really need this `let` here?
trinity-1686a reviewed 1 year ago
trinity-1686a commented 1 year ago

just to explicitly ignore a warning about unused result

just to explicitly ignore a warning about unused result

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 773fbfe7c8.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.