Plume/Plume

フォーク 24

Fix some federation issue #573

マージ済み

Plume_migration_agent が 6 個のコミットを fix/minor-federation-issue から master へマージ 2019-07-31 09:38:50 +00:00

trinity-1686a がコメント

2019-05-11 19:04:20 +00:00

オーナー

The issue in #567 will be a bit tougher than initially expected. Pterotype seems to use Organization instead of plain User for federation, so there is the question how do we manage that? How do we treat that? As users I expect, but it will require some changes to do so, or as something else?

elegaanz がコメント

2019-05-11 19:29:38 +00:00

(github.comから移行)

A post must have an associated blog, but it technically can have no author. So I would say Organizations should be treated as blogs.

You can probably create a type that implements AsActor and the different AsObject, but that actually delegates the work to Blog? I don't know.

A post must have an associated blog, but it technically can have no author. So I would say Organizations should be treated as blogs. You can probably create a type that implements `AsActor` and the different `AsObject`, but that actually delegates the work to `Blog`? I don't know.

👍 1

trinity-1686a がコメント

2019-05-11 19:40:41 +00:00

作成者

オーナー

atm a post can't really have no authors : in multiple places assumption is made that there is at least one author, and we can use posts.get_authors()?[0] safely. There will be things to change if we introduce the possibility of a post without authors. Also as one can't follow a blog yet, this would mean a basic feature is lacking. The more I think about it, the more problematic it get

atm a post can't really have no authors : in multiple places assumption is made that there is at least one author, and we can use `posts.get_authors()?[0]` safely. There will be things to change if we introduce the possibility of a post without authors. Also as one can't follow a blog yet, this would mean a basic feature is lacking. The more I think about it, the more problematic it get

codecov[bot] がコメント

2019-05-11 19:49:49 +00:00

(github.comから移行)

Codecov Report

Merging #573 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   35.35%   35.35%   -0.01%     
==========================================
  Files          68       68              
  Lines        7914     7915       +1     
  Branches     1893     1894       +1     
==========================================
  Hits         2798     2798              
- Misses       4340     4341       +1     
  Partials      776      776

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/573?src=pr&el=h1) Report > Merging [#573](https://codecov.io/gh/Plume-org/Plume/pull/573?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c031804464a22c550ff621483811a202ecbb238c?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #573 +/- ## ========================================== - Coverage 35.35% 35.35% -0.01% ========================================== Files 68 68 Lines 7914 7915 +1 Branches 1893 1894 +1 ========================================== Hits 2798 2798 - Misses 4340 4341 +1 Partials 776 776 ```

elegaanz がコメント

2019-05-11 20:05:19 +00:00

(github.comから移行)

OK, so then, what about inserting both a blog and an user with the same username when encountering an Organization? It is a bit hackish, but it should work.

Also, we should maybe add a "default" personnal blog for users at some, as I think it is what most people expect (but it may make the whole code a lot more complex too)?

OK, so then, what about inserting both a blog and an user with the same username when encountering an `Organization`? It is a bit hackish, but it should work. Also, we should maybe add a "default" personnal blog for users at some, as I think it is what most people expect (but it may make the whole code a lot more complex too)?

👍 1

marek-lach がコメント

2019-05-11 21:42:10 +00:00

(github.comから移行)

This may be useful to cunsult for reference:

https://github.com/w3c/activitypub/issues/260

There may (or may not) be some similarity to this Pleroma issue:

https://git.pleroma.social/pleroma/pleroma/issues/364

This may be useful to _cunsult for reference_: https://github.com/w3c/activitypub/issues/260 There may (or may not) be _some similarity_ to this Pleroma issue: https://git.pleroma.social/pleroma/pleroma/issues/364

marek-lach がコメント

2019-05-16 15:20:34 +00:00

(github.comから移行)

@fdb-hiroshima @BaptisteGelez According to the creator of Pterotype, Organization is the entire blog, not a specific user in the current design of the plugin.

I think this may help to shed some light on the issue at hand:
Screenshot 2019-05-16 at 17 12 46

He plans to redesign the federation approach in the future though, and test it against Plume himself then.

@fdb-hiroshima @BaptisteGelez According to the creator of _Pterotype_, `Organization` is the entire blog, not a specific user in the current design of the plugin. I think this may help to shed some light on the issue at hand: <img width="304" alt="Screenshot 2019-05-16 at 17 12 46" src="https://user-images.githubusercontent.com/45913977/57866013-e3472580-77fe-11e9-8166-e96f8632d9c1.png"> He plans to redesign the federation approach in the future though, and test it against Plume himself then.

👍 2

trinity-1686a がコメント

2019-07-07 16:04:30 +00:00

作成者

オーナー

this has been stall for too long. What has been fixed has been fixed, the rest will be at some point in the future

👍 3

elegaanz (github.comから移行) がレビュー 2019-07-30 21:16:14 +00:00

elegaanz (github.comから移行) がコメント

What you have done looks good 👍 If you could just cancel the changes to the translation files (or fix the conflicts with master, but the former is probably easier), we could merge this PR.

What you have done looks good :+1: If you could just cancel the changes to the translation files (or fix the conflicts with master, but the former is probably easier), we could merge this PR.

elegaanz (github.comから移行) がレビュー 2019-07-31 08:12:28 +00:00

elegaanz がコメント

2019-07-31 08:13:27 +00:00

(github.comから移行)

Wait I just realized: do we fetch blogs with the group: prefix in Webfinger now?

Wait I just realized: do we fetch blogs with the `group:` prefix in Webfinger now?

trinity-1686a がコメント

2019-07-31 08:59:26 +00:00

作成者

オーナー

no, we don't 😬

😆 1

elegaanz (github.comから移行) が変更を承認 2019-07-31 09:38:34 +00:00

elegaanz (github.comから移行) がコメント

This time it looks good, thanks!

サインインしてこの会話に参加。

レビューアなし

elegaanz

マイルストーンなし

プロジェクトなし

担当者なし

2 人の参加者

通知

期日

期日が正しくないか範囲を超えています。 "yyyy-mm-dd" の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#573

説明はありません。

Rows
Columns