Plume
/
Plume
8
16
포크 22
코드 이슈 174 풀 리퀘스트 8 릴리즈 8 위키 활동

레이블 마일스톤

refactor code to use Shrinkwraprs and diesel-derive-newtype #598

병합
igalic refactor/shrinkwraps 에서 master 로 6 commits 를 머지했습니다 5 년 전
대화 1 커밋 6 파일 변경됨 38
igalic 코멘트됨, 5 년 전 (Migrated from github.com)

Reduce a lot of our own boilerplate with these two crates.
This fixes #597.

Reduce a lot of our own boilerplate with these two crates. This fixes #597.
👍 1 ❤️ 1
codecov[bot] 코멘트됨, 5 년 전 (Migrated from github.com)

Codecov Report

Merging #598 into master will increase coverage by 0.09%.
The diff coverage is 16.66%.

@@            Coverage Diff            @@
##           master    #598      +/-   ##
=========================================
+ Coverage    34.5%   34.6%   +0.09%     
=========================================
  Files          67      67              
  Lines        7876    7840      -36     
  Branches     1890    1883       -7     
=========================================
- Hits         2718    2713       -5     
+ Misses       4398    4367      -31     
  Partials      760     760
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/598?src=pr&el=h1) Report > Merging [#598](https://codecov.io/gh/Plume-org/Plume/pull/598?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/59023e96023405847b3a91658e0adffecceb993d?src=pr&el=desc) will **increase** coverage by `0.09%`. > The diff coverage is `16.66%`. ```diff @@ Coverage Diff @@ ## master #598 +/- ## ========================================= + Coverage 34.5% 34.6% +0.09% ========================================= Files 67 67 Lines 7876 7840 -36 Branches 1890 1883 -7 ========================================= - Hits 2718 2713 -5 + Misses 4398 4367 -31 Partials 760 760 ```
elegaanz (Migrated from github.com) 검토됨 5 년 전
plume-models/src/reshares.rs
@ -140,26 +140,12 @@ impl FromId<PlumeRocket> for Reshare {
let res = Reshare::insert(
&c.conn,
NewReshare {
elegaanz (Migrated from github.com) 코멘트됨, 5 년 전

I think you can even replace this block with just &act.announce_props.object_link::<Id>()?, it was only here to be able to convert the Id to a String (and same for other similar blocks).

I think you can even replace this block with just `&act.announce_props.object_link::<Id>()?`, it was only here to be able to convert the Id to a String (and same for other similar blocks).
trinity-1686a 이 변경사항을 승인하였습니다. 5 년 전

리뷰어

trinity-1686a 이 변경사항을 승인하였습니다. 5 년 전
The pull request has been merged as 8c59c822b6.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b refactor/shrinkwraps master
git pull origin refactor/shrinkwraps

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff refactor/shrinkwraps
git push origin master
로그인하여 이 대화에 참여
리뷰어
Request review
No reviewers
trinity-1686a
레이블
Apply labels
레이블 초기화   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
레이블 없음
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
마일스톤
Set milestone
마일스톤 초기화
No items
마일스톤 없음
담당자
Assign users
담당자 초기화
담당자 없음
참여자 2명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: Plume/Plume#598
쓰기 미리보기
불러오는 중...
취소
저장
아직 콘텐츠가 없습니다.
'refactor/shrinkwraps' 브랜치 삭제

Deleting a branch is permanent. It CANNOT be undone. Continue?

아니오
예