add enum containing all successful route returns #614

マージ済み

igalic が 10 個のコミットを refactor/route-result から master へマージ

igalic がコメント (github.comから移行)

This enum derives Responder, so it can be used as route result.
We also implement From, so it can be converted

This pr addresses #613

This enum derives `Responder`, so it can be used as route result. We also implement `From`, so it can be converted This pr addresses #613

codecov[bot] がコメント (github.comから移行)

Codecov Report

Merging #614 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   35.31%   35.31%           
=======================================
  Files          68       68           
  Lines        7907     7907           
  Branches     1893     1893           
=======================================
  Hits         2792     2792           
  Misses       4345     4345           
  Partials      770      770

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/614?src=pr&el=h1) Report > Merging [#614](https://codecov.io/gh/Plume-org/Plume/pull/614?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/4b205fa995a6935a2512a9725d84635e889db48e?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #614 +/- ## ======================================= Coverage 35.31% 35.31% ======================================= Files 68 68 Lines 7907 7907 Branches 1893 1893 ======================================= Hits 2792 2792 Misses 4345 4345 Partials 770 770 ```

igalic がコメント (github.comから移行)

I've marked this pull request now ready for review.
even though there's at least one function left that could be improved (in readability, or at least refractored to use this enum)
but i don't think we can make further strides without improving our ErrorPage

I've marked this pull request now ready for review. even though there's at least one function left that could be improved (in readability, or at least refractored to use this enum) but i don't think we can make further strides without improving our ErrorPage

rfwatson (github.comから移行) がレビュー

src/routes/blogs.rs

rfwatson (github.comから移行) がコメント

So if I read this correctly, the Rust compiler infers the type from the return type of the function, allowing into() to function as expected?

Even though I should probably expect that from Rust, that's still pretty neat.

So if I read this correctly, the Rust compiler infers the type from the return type of the function, allowing `into()` to function as expected? Even though I should probably expect that from Rust, that's still pretty neat.

trinity-1686a がレビュー

trinity-1686a がコメント

オーナー

👍

:+1:

src/routes/session.rs

trinity-1686a がコメント

オーナー

Isn't it a bit strange that when redirecting to invalid uri, it gives an error? It would probably make more sens that the chain on line 100 does the parsing to, and default to parse("/").unwrap(). Also it should probably be a Origin to block redirection to other domain
(this is also true for previous code, it's pretty old, I'm pretty sure we did not do code review last September)

Isn't it a bit strange that when redirecting to invalid uri, it gives an error? It would probably make more sens that the chain on line 100 does the parsing to, and default to `parse("/").unwrap()`. Also it should probably be a [Origin](https://api.rocket.rs/v0.4/rocket/http/uri/struct.Origin.html) to block redirection to other domain (this is also true for previous code, it's pretty old, I'm pretty sure we did not do code review last September)

igalic (github.comから移行) がレビュー

src/routes/session.rs

igalic (github.comから移行) がコメント

do you have a suggestion for improvement?

trinity-1686a がレビュー

src/routes/session.rs

trinity-1686a がコメント

オーナー

I do but I don't know how to explain it with words, so I'll probably do it myself during the week end

trinity-1686a が変更を承認

igalic (github.comから移行) がレビュー

src/routes/session.rs

igalic (github.comから移行) がコメント

well, I'll be happy to review it then, and help with words where necessary

i used to be quite good with words, now i'm procrastinating on writing words, by working on a blogging platform.

well, I'll be happy to review it then, and help with words where necessary i used to be quite good with words, now i'm procrastinating on writing words, by working on a blogging platform.

レビューア

trinity-1686a が変更を承認

プルリクエストは 3d27e283ad でマージされています。

コマンドラインの手順も確認できます。

ステップ 1:

あなたのプロジェクトリポジトリで新しいブランチをチェックアウトし、変更内容をテストします。

git checkout -b refactor/route-result master

git pull origin refactor/route-result

ステップ 2:

変更内容をマージして、Forgejoに反映します。

git checkout master

git merge --no-ff refactor/route-result

git push origin master

サインインしてこの会話に参加。

レビューアなし

マイルストーンなし

担当者なし

2 人の参加者

通知

期日

期日が正しくないか範囲を超えています。 'yyyy-mm-dd' の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

読み込み中…

まだ内容がありません

ラベル マイルストーン

add enum containing all successful route returns #614

Codecov Report

レビューア

ステップ 1:

ステップ 2:

ラベルマイルストーン