Fix theme caching #647

Merged

elegaanz merged 1 commit from fix-theme-caching into master

2019-08-21 19:41:12 +00:00

elegaanz commented

2019-08-21 18:13:11 +00:00

(Migrated from github.com)

The directory was wrong, which led to 404 errors
reads_to_string was consuming the File, so the response was always empty

Fixes #645

- The directory was wrong, which led to 404 errors - `reads_to_string` was consuming the `File`, so the response was always empty Fixes #645

codecov[bot] commented

2019-08-21 18:42:04 +00:00

(Migrated from github.com)

Codecov Report

Merging #647 into master will increase coverage by 0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   35.06%   35.11%   +0.04%     
==========================================
  Files          68       68              
  Lines        7945     7943       -2     
  Branches     1890     1889       -1     
==========================================
+ Hits         2786     2789       +3     
+ Misses       4383     4374       -9     
- Partials      776      780       +4

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/647?src=pr&el=h1) Report > Merging [#647](https://codecov.io/gh/Plume-org/Plume/pull/647?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a6c84daa1a242246ac01260eb9bc201dd6e47830?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `75%`. ```diff @@ Coverage Diff @@ ## master #647 +/- ## ========================================== + Coverage 35.06% 35.11% +0.04% ========================================== Files 68 68 Lines 7945 7943 -2 Branches 1890 1889 -1 ========================================== + Hits 2786 2789 +3 + Misses 4383 4374 -9 - Partials 776 780 +4 ```

igalic (Migrated from github.com) approved these changes 2019-08-21 18:52:52 +00:00

igalic (Migrated from github.com) left a comment

🤔… 👍

No reviewers

igalic

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#647

No description provided.

Rows
Columns