#647 Fix theme caching

Merged
elegaanz merged 1 commits from fix-theme-caching into master 1 year ago
elegaanz commented 1 year ago (Migrated from github.com)
  • The directory was wrong, which led to 404 errors
  • reads_to_string was consuming the File, so the response was always empty

Fixes #645

- The directory was wrong, which led to 404 errors - `reads_to_string` was consuming the `File`, so the response was always empty Fixes #645
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #647 into master will increase coverage by 0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   35.06%   35.11%   +0.04%     
==========================================
  Files          68       68              
  Lines        7945     7943       -2     
  Branches     1890     1889       -1     
==========================================
+ Hits         2786     2789       +3     
+ Misses       4383     4374       -9     
- Partials      776      780       +4
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/647?src=pr&el=h1) Report > Merging [#647](https://codecov.io/gh/Plume-org/Plume/pull/647?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a6c84daa1a242246ac01260eb9bc201dd6e47830?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `75%`. ```diff @@ Coverage Diff @@ ## master #647 +/- ## ========================================== + Coverage 35.06% 35.11% +0.04% ========================================== Files 68 68 Lines 7945 7943 -2 Branches 1890 1889 -1 ========================================== + Hits 2786 2789 +3 + Misses 4383 4374 -9 - Partials 776 780 +4 ```
igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

🤔👍

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 28fb50438e.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.