Labels Milestones

New Pull Request

Fix theme caching #647

Merged

elegaanz merged 1 commits from fix-theme-caching into master 2 years ago

Conversation 1 Commits 1 Files Changed 2

elegaanz commented 2 years ago (Migrated from github.com)

Owner

• The directory was wrong, which led to 404 errors
• reads_to_string was consuming the File, so the response was always empty

Fixes #645

- The directory was wrong, which led to 404 errors - `reads_to_string` was consuming the `File`, so the response was always empty Fixes #645

codecov[bot] commented 2 years ago (Migrated from github.com)

Owner

Codecov Report

Merging #647 into master will increase coverage by 0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   35.06%   35.11%   +0.04%     
==========================================
  Files          68       68              
  Lines        7945     7943       -2     
  Branches     1890     1889       -1     
==========================================
+ Hits         2786     2789       +3     
+ Misses       4383     4374       -9     
- Partials      776      780       +4

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/647?src=pr&el=h1) Report > Merging [#647](https://codecov.io/gh/Plume-org/Plume/pull/647?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a6c84daa1a242246ac01260eb9bc201dd6e47830?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `75%`. ```diff @@ Coverage Diff @@ ## master #647 +/- ## ========================================== + Coverage 35.06% 35.11% +0.04% ========================================== Files 68 68 Lines 7945 7943 -2 Branches 1890 1889 -1 ========================================== + Hits 2786 2789 +3 + Misses 4383 4374 -9 - Partials 776 780 +4 ```

igalic (Migrated from github.com) approved these changes 2 years ago

igalic (Migrated from github.com) left a comment

🤔… 👍

Reviewers

igalic

The pull request has been merged as 28fb50438e.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

igalic

Labels

Apply labels

Clear labels

A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on

No Label A: API A: Backend A: Federation A: Front-End A: I18N A: Meta A: Security Build C: Bug C: Discussion C: Enhancement C: Feature Compatibility Dependency Design Documentation Good first issue Help welcome Mobile Rendering S: Blocked S: Duplicate S: Incomplete S: Instance specific S: Invalid S: Needs Voting/Discussion S: Ready for review Suggestion S: Voted on Loomio S: Wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.