Plume
/
Plume
8
16
Fork 22
Code Issues 174 Pull Requests 8 Releases 8 Wiki Activity

Labels Milestones

New Pull Request

Fix issue #642, frontend not in english if the user language does not exist #648

Merged
requiem958 merged 2 commits from issue-frontend-language into master 5 years ago
Conversation 2 Commits 2 Files Changed 1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File

7
plume-front/src/main.rs
Unescape Escape View File

@ -46,10 +46,15 @@ lazy_static! {
let catalogs = include_i18n!();
let lang = js! { return navigator.language }.into_string().unwrap();
let lang = lang.splitn(2, '-').next().unwrap_or("en");
let english_position = catalogs
igalic commented 5 years ago (Migrated from github.com)
Review

this should be either a (cached?) constant, or a (cached?) config value

this should be either a (cached?) constant, or a (cached?) config value
requiem958 commented 5 years ago (Migrated from github.com)
Review

It should be a constant yes, but the rust doc of constant says :

Constants can be set only to a constant expression and not to the result of a function call or any other value that will be computed at runtime.

So i thought the keyword const was forbidden in this case.

It should be a constant yes, but the rust doc of constant says : > Constants can be set only to a constant expression and not to the result of a function call or any other value that will be computed at runtime. So i thought the keyword const was forbidden in this case.
trinity-1686a commented 5 years ago
Review

All this is in a lazy_static! call, so the result will be evaluated only one time, the first time CATALOG is accessed. The only thing it's not is cached between two different page loading, but that's not necessary imo

All this is in a lazy_static! call, so the result will be evaluated only one time, the first time CATALOG is accessed. The only thing it's not is cached between two different page loading, but that's not necessary imo
.iter()
.position(|(language_code, _)| *language_code == "en")
.unwrap();
igalic commented 5 years ago (Migrated from github.com)
Review

while i understand that this is a simple operation, i don't think we need to do it every time

while i understand that this is a simple operation, i don't think we need to do it every time
igalic commented 5 years ago (Migrated from github.com)
Review

actually, never mind, this is an operation that's only dealing with things known at compile time

the optimiser will probably inline this as a constant literal

actually, never mind, this is an operation that's only dealing with things known at compile time the optimiser will probably inline this as a constant literal
catalogs
.iter()
.find(|(l, _)| l == &lang)
.unwrap_or(&catalogs[0])
.unwrap_or(&catalogs[english_position])
.clone()
.1
};

Write Preview
Loading…
Cancel
Save