Plume/Plume

Fork 24

delete notification on user deletion #658

Merged

Plume_migration_agent merged 5 commits from bugfix/651 into master

2019-09-13 09:29:53 +00:00

trinity-1686a commented

2019-08-27 12:27:02 +00:00

Owner

fix #651

before merging, I'd like to add a regression test

fix #651 before merging, I'd like to add a regression test

👍 1

codecov[bot] commented

2019-08-27 14:21:05 +00:00

(Migrated from github.com)

Codecov Report

Merging #658 into master will increase coverage by 0.58%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   34.58%   35.17%   +0.58%     
==========================================
  Files          68       68              
  Lines        8020     7952      -68     
  Branches     1890     1893       +3     
==========================================
+ Hits         2774     2797      +23     
+ Misses       4468     4374      -94     
- Partials      778      781       +3

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/658?src=pr&el=h1) Report > Merging [#658](https://codecov.io/gh/Plume-org/Plume/pull/658?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d46af6fe5bb472d0aa9435520690c3b94a3ec577?src=pr&el=desc) will **increase** coverage by `0.58%`. > The diff coverage is `70%`. ```diff @@ Coverage Diff @@ ## master #658 +/- ## ========================================== + Coverage 34.58% 35.17% +0.58% ========================================== Files 68 68 Lines 8020 7952 -68 Branches 1890 1893 +3 ========================================== + Hits 2774 2797 +23 + Misses 4468 4374 -94 - Partials 778 781 +3 ```

elegaanz (Migrated from github.com) requested changes 2019-08-27 20:30:26 +00:00

plume-models/src/notifications.rs

elegaanz (Migrated from github.com) commented

2019-08-27 20:30:22 +00:00

object_id is the ID of the Follow object actually.

`object_id` is the ID of the `Follow` object actually.

elegaanz (Migrated from github.com) reviewed 2019-08-28 09:40:35 +00:00

elegaanz (Migrated from github.com) left a comment

If the tests pass, you can merge!

trinity-1686a commented

2019-09-13 08:15:48 +00:00

Author

Owner

this has been stall for a bit, and I don't have time to fix the CI (the problem is not related to the fix, but to the way integration tests are run). I'll revert latests commit so we can merge it as is

igalic (Migrated from github.com) approved these changes 2019-09-13 08:41:13 +00:00

igalic (Migrated from github.com) left a comment

👍

No reviewers

elegaanz

igalic

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#658

No description provided.

Rows
Columns