Plume/Plume
9
18
Fork 24
Code Issues 180 Pull requests 8 Releases 8 Wiki Activity

order media so that latest added are top #660

Merged
Plume_migration_agent merged 2 commits from feature/621 into master 2019-08-28 09:37:04 +00:00
Conversation 1 Commits 2 Files changed 1 +9 -1
trinity-1686a commented 2019-08-27 13:41:10 +00:00
Owner
Copy link

partial fix for #621

partial fix for #621
codecov[bot] commented 2019-08-27 14:00:21 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #660 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   35.11%   35.15%   +0.04%     
==========================================
  Files          68       68              
  Lines        7943     7950       +7     
  Branches     1889     1889              
==========================================
+ Hits         2789     2795       +6     
- Misses       4374     4375       +1     
  Partials      780      780
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=h1) Report > Merging [#660](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/935d331e971bc19019a4cbc271b3a59719b6be93?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `85.71%`. ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== + Coverage 35.11% 35.15% +0.04% ========================================== Files 68 68 Lines 7943 7950 +7 Branches 1889 1889 ========================================== + Hits 2789 2795 +6 - Misses 4374 4375 +1 Partials 780 780 ```
igalic (Migrated from github.com) reviewed 2019-08-27 14:17:58 +00:00
igalic (Migrated from github.com) left a comment
Copy link

❓

❓
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrated from github.com) commented 2019-08-27 14:17:47 +00:00
Copy link

is this guaranteed to be such?
do we have a create date anywhere?

is this guaranteed to be such? do we have a create date anywhere?
trinity-1686a reviewed 2019-08-27 14:26:11 +00:00
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
trinity-1686a commented 2019-08-27 14:26:10 +00:00
Author
Owner
Copy link

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)
igalic (Migrated from github.com) reviewed 2019-08-27 14:27:16 +00:00
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrated from github.com) commented 2019-08-27 14:27:16 +00:00
Copy link

i wonder if anyone expects that editing a media pushes it to the top again…

i wonder if anyone expects that editing a media pushes it to the top again…
elegaanz (Migrated from github.com) reviewed 2019-08-27 14:29:40 +00:00
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
elegaanz (Migrated from github.com) commented 2019-08-27 14:29:39 +00:00
Copy link

We can't edit media information for the moment, so…

We can't edit media information for the moment, so…
igalic (Migrated from github.com) reviewed 2019-08-27 14:36:43 +00:00
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrated from github.com) commented 2019-08-27 14:36:43 +00:00
Copy link

well then… pushes [resolve] button

well then… *pushes [resolve] button*
elegaanz (Migrated from github.com) reviewed 2019-08-27 20:31:19 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Ideally, it should be done for the paginated version too, so that /media lists them in the correct order.

Ideally, it should be done for the paginated version too, so that `/media` lists them in the correct order.
igalic (Migrated from github.com) approved these changes 2019-08-28 08:50:38 +00:00
igalic (Migrated from github.com) left a comment
Copy link

👍

:+1:
Sign in to join this conversation.
Reviewers
No reviewers
igalic
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#660
No description provided.
Delete branch "feature/621"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?