#667 snap: Ensure cargo-web doesn't erroneously adopt our workspace.

Merged
RAOF merged 1 commits from fix-snapcraft-build into master 1 year ago
RAOF commented 1 year ago (Migrated from github.com)

Because snapcraft pulls the source into a subdirectory of Plume’s source, and
Cargo will implicitly and recursively search parent directories for a [Workspace],
Cargo believes that cargo-web should be in Plume’s workspace.

However, Cargo then errors out because Plume’s [Workspace] stanza (entirely correctly)
doens’t mention cargo-web.

Adding an empty [Workspace] stanza to cargo-web’s Cargo.toml disables Cargo’s implicit
search for a workspace to adopt, and avoids this problem.

Because snapcraft pulls the source into a subdirectory of Plume's source, and Cargo will implicitly and recursively search parent directories for a [Workspace], Cargo believes that cargo-web should be in Plume's workspace. However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly) doens't mention cargo-web. Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit search for a workspace to adopt, and avoids this problem.
trinity-1686a approved these changes 1 year ago
trinity-1686a left a comment

👍
(ci error is about uploading to plume-ci for live testing, not required here)

Reviewers

trinity-1686a approved these changes 1 year ago
The pull request has been merged as b36e12b654.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.