Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 8 Releases 8 Wiki Activity

snap: Ensure cargo-web doesn't erroneously adopt our workspace. #667

Merged
RAOF merged 1 commit from fix-snapcraft-build into master 2019-09-18 14:24:16 +00:00
Conversation 0 Commits 1 Files changed 1 +3
RAOF commented 2019-09-18 12:57:17 +00:00 (Migrated from github.com)
Copy link

Because snapcraft pulls the source into a subdirectory of Plume's source, and
Cargo will implicitly and recursively search parent directories for a [Workspace],
Cargo believes that cargo-web should be in Plume's workspace.

However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly)
doens't mention cargo-web.

Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit
search for a workspace to adopt, and avoids this problem.

Because snapcraft pulls the source into a subdirectory of Plume's source, and Cargo will implicitly and recursively search parent directories for a [Workspace], Cargo believes that cargo-web should be in Plume's workspace. However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly) doens't mention cargo-web. Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit search for a workspace to adopt, and avoids this problem.
trinity-1686a approved these changes 2019-09-18 13:32:49 +00:00
trinity-1686a left a comment
Owner
Copy link

👍
(ci error is about uploading to plume-ci for live testing, not required here)

👍 (ci error is about uploading to plume-ci for live testing, not required here)
Sign in to join this conversation.
Reviewers
No reviewers
trinity-1686a
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#667
No description provided.
Delete branch "fix-snapcraft-build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?