Plume
/
Plume
7
9
Fork 8
Code Issues 132 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#667 snap: Ensure cargo-web doesn't erroneously adopt our workspace.

Merged
RAOF merged 1 commits from fix-snapcraft-build into master 1 year ago
Conversation 0 Commits 1 Files Changed 1
RAOF commented 1 year ago (Migrated from github.com)

Because snapcraft pulls the source into a subdirectory of Plume’s source, and
Cargo will implicitly and recursively search parent directories for a [Workspace],
Cargo believes that cargo-web should be in Plume’s workspace.

However, Cargo then errors out because Plume’s [Workspace] stanza (entirely correctly)
doens’t mention cargo-web.

Adding an empty [Workspace] stanza to cargo-web’s Cargo.toml disables Cargo’s implicit
search for a workspace to adopt, and avoids this problem.

Because snapcraft pulls the source into a subdirectory of Plume's source, and Cargo will implicitly and recursively search parent directories for a [Workspace], Cargo believes that cargo-web should be in Plume's workspace. However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly) doens't mention cargo-web. Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit search for a workspace to adopt, and avoids this problem.
trinity-1686a approved these changes 1 year ago
trinity-1686a left a comment

👍
(ci error is about uploading to plume-ci for live testing, not required here)

Reviewers

trinity-1686a approved these changes 1 year ago
The pull request has been merged as b36e12b654.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 trinity-1686a
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix-snapcraft-build'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes