snap: Ensure cargo-web doesn't erroneously adopt our workspace. #667

Sammanfogat
RAOF sammanfogade 1 incheckningar från fix-snapcraft-build in i master 5 år sedan
RAOF kommenterad 5 år sedan (Migrerad från github.com)

Because snapcraft pulls the source into a subdirectory of Plume's source, and
Cargo will implicitly and recursively search parent directories for a [Workspace],
Cargo believes that cargo-web should be in Plume's workspace.

However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly)
doens't mention cargo-web.

Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit
search for a workspace to adopt, and avoids this problem.

Because snapcraft pulls the source into a subdirectory of Plume's source, and Cargo will implicitly and recursively search parent directories for a [Workspace], Cargo believes that cargo-web should be in Plume's workspace. However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly) doens't mention cargo-web. Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit search for a workspace to adopt, and avoids this problem.
trinity-1686a godkände dessa ändringar 5 år sedan
trinity-1686a lämnade en kommentar
Ägare

👍
(ci error is about uploading to plume-ci for live testing, not required here)

👍 (ci error is about uploading to plume-ci for live testing, not required here)

Granskare

trinity-1686a godkände dessa ändringar 5 år sedan
Pull-förfrågan har sammanfogats som b36e12b654.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b fix-snapcraft-build master
git pull origin fix-snapcraft-build

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff fix-snapcraft-build
git push origin master
Logga in för att delta i denna konversation.
Inga granskare
Ingen Milsten
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: Plume/Plume#667
Laddar…
Det finns inget innehåll än.