#683 Add environmental variable to control path of media

Merged
epsilon-phase merged 1 commits from Media-path into master 1 year ago
epsilon-phase commented 1 year ago (Migrated from github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```
RAOF (Migrated from github.com) reviewed 1 year ago
RAOF (Migrated from github.com) left a comment

This looks correct to me; I’m not familiar with Rocket’s #[get()] routing stuff, so someone else should check that this is correct.

I’ll give it a test! Thanks!

igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

👀

Plume_migration_agent commented 1 year ago

is this supposed to be deterministic?

is this supposed to be deterministic?
epsilon-phase (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don’t think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)
igalic (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

I haven’t tested yet, but apart from a minor path mistake, it looks good to me 🙂

trinity-1686a commented 1 year ago

the media part is already included in the default value of media_directory (static/media). I don’t know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much
epsilon-phase (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Oh, thanks for the catch.

Oh, thanks for the catch.
RAOF commented 1 year ago (Migrated from github.com)
Owner

I’ve built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I’ll push a PR for the snapcraft metadata and we’ll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Looks good to me! Thank you for your help! 👍

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 866465c603.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.