Plume
/
Plume
7
9
Fork 8
Code Issues 131 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#683 Add environmental variable to control path of media

Merged
epsilon-phase merged 1 commits from Media-path into master 1 year ago
Conversation 2 Commits 1 Files Changed 5
epsilon-phase commented 1 year ago (Migrated from github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```
RAOF (Migrated from github.com) reviewed 1 year ago
RAOF (Migrated from github.com) left a comment

This looks correct to me; I’m not familiar with Rocket’s #[get()] routing stuff, so someone else should check that this is correct.

I’ll give it a test! Thanks!

igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

👀

src/routes/medias.rs
Plume_migration_agent commented 1 year ago

is this supposed to be deterministic?

is this supposed to be deterministic?
epsilon-phase (Migrated from github.com) reviewed 1 year ago
src/routes/medias.rs
Plume_migration_agent commented 1 year ago

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don’t think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)
igalic (Migrated from github.com) reviewed 1 year ago
src/routes/medias.rs
Plume_migration_agent commented 1 year ago

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

I haven’t tested yet, but apart from a minor path mistake, it looks good to me 🙂

plume-models/src/medias.rs
trinity-1686a commented 1 year ago

the media part is already included in the default value of media_directory (static/media). I don’t know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much
epsilon-phase (Migrated from github.com) reviewed 1 year ago
plume-models/src/medias.rs
Plume_migration_agent commented 1 year ago

Oh, thanks for the catch.

Oh, thanks for the catch.
RAOF commented 1 year ago (Migrated from github.com)
Owner

I’ve built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I’ll push a PR for the snapcraft metadata and we’ll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:
🎉 3
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Looks good to me! Thank you for your help! 👍

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 866465c603.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 Plume_migration_agent
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'Media-path'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes