Plume/Plume

Fork 24

Add environmental variable to control path of media #683

Merged

epsilon-phase merged 1 commit from Media-path into master

2019-10-28 21:28:29 +00:00

epsilon-phase commented

2019-10-24 17:10:15 +00:00

(Migrated from github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`

codecov[bot] commented

2019-10-24 17:28:53 +00:00

(Migrated from github.com)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```

RAOF (Migrated from github.com) reviewed 2019-10-27 01:06:34 +00:00

RAOF (Migrated from github.com) left a comment

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!

igalic (Migrated from github.com) reviewed 2019-10-27 17:32:52 +00:00

igalic (Migrated from github.com) left a comment

👀

src/routes/medias.rs

igalic (Migrated from github.com) commented

2019-10-27 17:32:09 +00:00

is this supposed to be deterministic?

epsilon-phase (Migrated from github.com) reviewed 2019-10-27 17:36:38 +00:00

src/routes/medias.rs

epsilon-phase (Migrated from github.com) commented

2019-10-27 17:36:38 +00:00

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)

igalic (Migrated from github.com) reviewed 2019-10-27 17:56:44 +00:00

src/routes/medias.rs

igalic (Migrated from github.com) commented

2019-10-27 17:56:43 +00:00

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)

trinity-1686a reviewed 2019-10-27 21:19:36 +00:00

trinity-1686a left a comment

Owner

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:

plume-models/src/medias.rs

trinity-1686a commented

2019-10-27 21:07:58 +00:00

Owner

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

epsilon-phase (Migrated from github.com) reviewed 2019-10-28 01:51:49 +00:00

plume-models/src/medias.rs

epsilon-phase (Migrated from github.com) commented

2019-10-28 01:51:49 +00:00

Oh, thanks for the catch.

RAOF commented

2019-10-28 07:04:48 +00:00

(Migrated from github.com)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:

🎉 3

elegaanz (Migrated from github.com) approved these changes 2019-10-28 21:28:20 +00:00

elegaanz (Migrated from github.com) left a comment

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

No reviewers

elegaanz

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#683

No description provided.

Rows
Columns