Add environmental variable to control path of media #683

Sapludināts

epsilon-phase sapludināja 1 revīzijas no Media-path uz master

epsilon-phase " komentēja " (Migrēts no github.com)

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being MEDIA_UPLOAD_DIRECTORY

This was a request made on the matrix chat that will make it possible to release a snap version, that environmental variable being `MEDIA_UPLOAD_DIRECTORY`

codecov[bot] " komentēja " (Migrēts no github.com)

Codecov Report

Merging #683 into master will decrease coverage by 0.03%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master    #683      +/-   ##
=========================================
- Coverage   39.83%   39.8%   -0.04%     
=========================================
  Files          72      72              
  Lines        9368    9383      +15     
  Branches     2219    2219              
=========================================
+ Hits         3732    3735       +3     
- Misses       4580    4592      +12     
  Partials     1056    1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=h1) Report > Merging [#683](https://codecov.io/gh/Plume-org/Plume/pull/683?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/dd6d39135e71cd4f4f22befb45da46d89d39ae33?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.05%`. ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================= - Coverage 39.83% 39.8% -0.04% ========================================= Files 72 72 Lines 9368 9383 +15 Branches 2219 2219 ========================================= + Hits 3732 3735 +3 - Misses 4580 4592 +12 Partials 1056 1056 ```

RAOF (Migrēts no github.com) recenzēja

RAOF (Migrēts no github.com) atstāja komentāru

This looks correct to me; I'm not familiar with Rocket's #[get()] routing stuff, so someone else should check that this is correct.

I'll give it a test! Thanks!

This looks correct to me; I'm not familiar with Rocket's `#[get()]` routing stuff, so someone else should check that this is correct. I'll give it a test! Thanks!

igalic (Migrēts no github.com) recenzēja

igalic (Migrēts no github.com) atstāja komentāru

👀

src/routes/medias.rs

igalic (Migrēts no github.com) " komentēja "

is this supposed to be deterministic?

epsilon-phase (Migrēts no github.com) recenzēja

src/routes/medias.rs

epsilon-phase (Migrēts no github.com) " komentēja "

Is it deterministic? It seems to come up with new GUIDs each piece we upload.
(We don't think we quite understand)

Is it deterministic? It seems to come up with new GUIDs each piece we upload. (We don't think we quite understand)

igalic (Migrēts no github.com) recenzēja

src/routes/medias.rs

igalic (Migrēts no github.com) " komentēja "

aah, never mind, i was thinking of something else
(the deterministially random id we use per release for our assets)

aah, never mind, i was thinking of something else (the deterministially random id we use per release for *our* assets)

trinity-1686a recenzēja

trinity-1686a atstāja komentāru

Īpašnieks

I haven't tested yet, but apart from a minor path mistake, it looks good to me 🙂

I haven't tested yet, but apart from a minor path mistake, it looks good to me :slightly_smiling_face:

plume-models/src/medias.rs

trinity-1686a " komentēja "

Īpašnieks

the media part is already included in the default value of media_directory (static/media). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

the `media` part is already included in the default value of media_directory (`static/media`). I don't know if it should be removed from here or from there (it depends on how custom directory should appear), but I think there is one too much

epsilon-phase (Migrēts no github.com) recenzēja

plume-models/src/medias.rs

epsilon-phase (Migrēts no github.com) " komentēja "

Oh, thanks for the catch.

RAOF " komentēja " (Migrēts no github.com)

I've built a snap from this locally, setting the new MEDIA_UPLOAD_DIRECTORY appropriately, and it works!

Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! 😁

I've built a snap from this locally, setting the new `MEDIA_UPLOAD_DIRECTORY` appropriately, and it works! Once this lands I'll push a PR for the snapcraft metadata and we'll have a fully-functional snap that I can then document! :grin:

🎉 3

elegaanz (Migrēts no github.com) apstiprināja izmaiņas

elegaanz (Migrēts no github.com) atstāja komentāru

Looks good to me! Thank you for your help! 👍

Looks good to me! Thank you for your help! :+1:

Recenzenti

Izmaiņu pieprasījums tika sapludināts ar revīziju 866465c603.

Varat aplūkot arī komandrindas instrukcijas.

Solis 1:

Projekta repozitorijā izveidojiet jaunu jaunu atzaru un pārbaudiet savas izmaiņas.

git checkout -b Media-path master

git pull origin Media-path

Solis 2:

Sapludināt izmaiņas un atjaunot tās Forgejo.

git checkout master

git merge --no-ff Media-path

git push origin master

Pierakstieties, lai pievienotos šai sarunai.

Nav recenzentu

Nav atskaites punktu

Nav atbildīgo

2 dalībnieki

Paziņojumi

Izpildes termiņš

Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Notiek ielāde…

Vēl nav satura.

Etiķetes Atskaites punkti

Add environmental variable to control path of media #683

Codecov Report

Recenzenti

Solis 1:

Solis 2: