#688 Add autosaving to the editor

Merged
epsilon-phase merged 6 commits from confirmation-autosave into master 1 year ago
epsilon-phase commented 1 year ago (Migrated from github.com)

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it’d be good to know if it’s wanted first since this seems like it might serve the same purpose

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #688 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #688   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          72       72           
  Lines        9494     9494           
  Branches     2263     2263           
=======================================
  Hits         3736     3736           
  Misses       4702     4702           
  Partials     1056     1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=h1) Report > Merging [#688](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/865f372d5a9c0866c7ec5215afb69d2916740c07?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #688 +/- ## ======================================= Coverage 39.35% 39.35% ======================================= Files 72 72 Lines 9494 9494 Branches 2263 2263 ======================================= Hits 3736 3736 Misses 4702 4702 Partials 1056 1056 ```
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

👀

trinity-1686a commented 1 year ago

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)
@@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
trinity-1686a commented 1 year ago

I guess set_interval does not exist? 😕

I guess set_interval does not exist? :confused:
epsilon-phase (Migrated from github.com) reviewed 1 year ago
@@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
Plume_migration_agent commented 1 year ago

It doesn’t look like it, oddly.

It doesn't look like it, oddly.
epsilon-phase (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

True enough, easy enough to add too

True enough, easy enough to add too
epsilon-phase (Migrated from github.com) reviewed 1 year ago
@@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
Plume_migration_agent commented 1 year ago

Okay, works fine in the js!

Okay, works fine in the `js!`
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) left a comment

I didn’t tested yet, but I left a few comments about the code itself.

Plume_migration_agent commented 1 year ago

Is the type hint really needed?

Is the type hint really needed?
Plume_migration_agent commented 1 year ago

Maybe this line should be removed ?

Maybe this line should be removed ?
Plume_migration_agent commented 1 year ago

This one too

This one too
Plume_migration_agent commented 1 year ago

You should use i18n! for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so.

i18n!(
    CATALOG,
    "Do you want to load the local autosave last edited at {}";
    Date::from_time(autosave_info.last_saved).to_date_string()
)
You should use `i18n!` for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so. ```rust i18n!( CATALOG, "Do you want to load the local autosave last edited at {}"; Date::from_time(autosave_info.last_saved).to_date_string() ) ```
Plume_migration_agent commented 1 year ago

Why does it need to be unsafe?

Why does it need to be `unsafe`?
epsilon-phase (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Oh, probably not

Oh, probably not
epsilon-phase (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Oh, it should probably just be unsafe on the lines that refer to the static mut

Oh, it should probably just be unsafe on the lines that refer to the `static mut`
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

No, I don’t know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.

No, I don't know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.
epsilon-phase (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

That option looked off to us too tbh.. At least on its own
Maybe it’d be better to use a RefCell or something?

That option looked off to us too tbh.. At least on its own Maybe it'd be better to use a RefCell or something?
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Anything that will prevent having unsafe code is fine (not that it is really unsafe, we only have one thread when running in the browser).

Anything that will prevent having `unsafe` code is fine (not that it is really unsafe, we only have one thread when running in the browser).
epsilon-phase (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Didn’t realize it was possible to do that with i18n!, that’s nifty :)

Didn't realize it was possible to do that with `i18n!`, that's nifty :)
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Works as expected, thank you!

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as c0469c69c1.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.