Add autosaving to the editor #688

Fusionado
epsilon-phase fusionados 6 commits de confirmation-autosave en master hace 4 años
epsilon-phase comentado hace 4 años (Migrado desde github.com)

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose
codecov[bot] comentado hace 4 años (Migrado desde github.com)

Codecov Report

Merging #688 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #688   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          72       72           
  Lines        9494     9494           
  Branches     2263     2263           
=======================================
  Hits         3736     3736           
  Misses       4702     4702           
  Partials     1056     1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=h1) Report > Merging [#688](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/865f372d5a9c0866c7ec5215afb69d2916740c07?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #688 +/- ## ======================================= Coverage 39.35% 39.35% ======================================= Files 72 72 Lines 9494 9494 Branches 2263 2263 ======================================= Hits 3736 3736 Misses 4702 4702 Partials 1056 1056 ```
trinity-1686a revisado hace 4 años
trinity-1686a dejó un comentario
Propietario

👀

:eyes:
Propietario

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
Propietario

I guess set_interval does not exist? 😕

I guess set_interval does not exist? :confused:
epsilon-phase (Migrado desde github.com) revisado hace 4 años
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
epsilon-phase (Migrado desde github.com) comentado hace 4 años

It doesn't look like it, oddly.

It doesn't look like it, oddly.
epsilon-phase (Migrado desde github.com) revisado hace 4 años
epsilon-phase (Migrado desde github.com) comentado hace 4 años

True enough, easy enough to add too

True enough, easy enough to add too
epsilon-phase (Migrado desde github.com) revisado hace 4 años
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
epsilon-phase (Migrado desde github.com) comentado hace 4 años

Okay, works fine in the js!

Okay, works fine in the `js!`
elegaanz (Migrado desde github.com) revisado hace 4 años
elegaanz (Migrado desde github.com) dejó un comentario

I didn't tested yet, but I left a few comments about the code itself.

I didn't tested yet, but I left a few comments about the code itself.
elegaanz (Migrado desde github.com) comentado hace 4 años

Is the type hint really needed?

Is the type hint really needed?
elegaanz (Migrado desde github.com) comentado hace 4 años

Maybe this line should be removed ?

Maybe this line should be removed ?
elegaanz (Migrado desde github.com) comentado hace 4 años

This one too

This one too
elegaanz (Migrado desde github.com) comentado hace 4 años

You should use i18n! for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so.

i18n!(
    CATALOG,
    "Do you want to load the local autosave last edited at {}";
    Date::from_time(autosave_info.last_saved).to_date_string()
)
You should use `i18n!` for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so. ```rust i18n!( CATALOG, "Do you want to load the local autosave last edited at {}"; Date::from_time(autosave_info.last_saved).to_date_string() ) ```
elegaanz (Migrado desde github.com) comentado hace 4 años

Why does it need to be unsafe?

Why does it need to be `unsafe`?
epsilon-phase (Migrado desde github.com) revisado hace 4 años
epsilon-phase (Migrado desde github.com) comentado hace 4 años

Oh, probably not

Oh, probably not
epsilon-phase (Migrado desde github.com) revisado hace 4 años
epsilon-phase (Migrado desde github.com) comentado hace 4 años

Oh, it should probably just be unsafe on the lines that refer to the static mut

Oh, it should probably just be unsafe on the lines that refer to the `static mut`
elegaanz (Migrado desde github.com) revisado hace 4 años
elegaanz (Migrado desde github.com) comentado hace 4 años

No, I don't know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.

No, I don't know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.
epsilon-phase (Migrado desde github.com) revisado hace 4 años
epsilon-phase (Migrado desde github.com) comentado hace 4 años

That option looked off to us too tbh.. At least on its own
Maybe it'd be better to use a RefCell or something?

That option looked off to us too tbh.. At least on its own Maybe it'd be better to use a RefCell or something?
elegaanz (Migrado desde github.com) revisado hace 4 años
elegaanz (Migrado desde github.com) comentado hace 4 años

Anything that will prevent having unsafe code is fine (not that it is really unsafe, we only have one thread when running in the browser).

Anything that will prevent having `unsafe` code is fine (not that it is really unsafe, we only have one thread when running in the browser).
epsilon-phase (Migrado desde github.com) revisado hace 4 años
epsilon-phase (Migrado desde github.com) comentado hace 4 años

Didn't realize it was possible to do that with i18n!, that's nifty :)

Didn't realize it was possible to do that with `i18n!`, that's nifty :)
elegaanz (Migrado desde github.com) aprobado estos cambios hace 4 años
elegaanz (Migrado desde github.com) dejó un comentario

Works as expected, thank you!

Works as expected, thank you!

Revisores

El Pull Request se ha fusionado como c0469c69c1.

Paso 1:

Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.
git checkout -b confirmation-autosave master
git pull origin confirmation-autosave

Paso 2:

Combine los cambios y actualice en Forgejo.
git checkout master
git merge --no-ff confirmation-autosave
git push origin master
Inicie sesión para unirse a esta conversación.
No hay revisores
Sin Milestone
No asignados
2 participantes
Notificaciones
Fecha de vencimiento
La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#688
Cargando…
Aún no existe contenido.