Plume/Plume
9
18
Fork 24
Código Incidencias 177 Pull requests 8 Lanzamientos 8 Wiki Actividad

Add autosaving to the editor #688

Fusionado
epsilon-phase fusionó 6 commits de confirmation-autosave en master 2019-11-02 14:14:41 +00:00
Conversación 1 Commits 6 Archivos modificados 4 +175 -7
epsilon-phase comentado 2019-10-31 22:50:19 +00:00 (Migrado desde github.com)
Copiar enlace

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose
codecov[bot] comentado 2019-10-31 23:13:41 +00:00 (Migrado desde github.com)
Copiar enlace

Codecov Report

Merging #688 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #688   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          72       72           
  Lines        9494     9494           
  Branches     2263     2263           
=======================================
  Hits         3736     3736           
  Misses       4702     4702           
  Partials     1056     1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=h1) Report > Merging [#688](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/865f372d5a9c0866c7ec5215afb69d2916740c07?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #688 +/- ## ======================================= Coverage 39.35% 39.35% ======================================= Files 72 72 Lines 9494 9494 Branches 2263 2263 ======================================= Hits 3736 3736 Misses 4702 4702 Partials 1056 1056 ```
trinity-1686a revisó 2019-11-01 00:23:33 +00:00
trinity-1686a dejó un comentario
Propietario
Copiar enlace

👀

:eyes:
plume-front/src/editor.rs
trinity-1686a comentado 2019-11-01 00:23:25 +00:00
Propietario
Copiar enlace

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)
plume-front/src/editor.rs
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
trinity-1686a comentado 2019-11-01 00:21:22 +00:00
Propietario
Copiar enlace

I guess set_interval does not exist? 😕

I guess set_interval does not exist? :confused:
epsilon-phase (Migrado desde github.com) revisó 2019-11-01 01:31:51 +00:00
plume-front/src/editor.rs
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
epsilon-phase (Migrado desde github.com) comentado 2019-11-01 01:31:50 +00:00
Copiar enlace

It doesn't look like it, oddly.

It doesn't look like it, oddly.
epsilon-phase (Migrado desde github.com) revisó 2019-11-01 01:32:14 +00:00
plume-front/src/editor.rs
epsilon-phase (Migrado desde github.com) comentado 2019-11-01 01:32:14 +00:00
Copiar enlace

True enough, easy enough to add too

True enough, easy enough to add too
epsilon-phase (Migrado desde github.com) revisó 2019-11-01 02:23:27 +00:00
plume-front/src/editor.rs
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
epsilon-phase (Migrado desde github.com) comentado 2019-11-01 02:23:27 +00:00
Copiar enlace

Okay, works fine in the js!

Okay, works fine in the `js!`
elegaanz (Migrado desde github.com) revisó 2019-11-01 20:06:50 +00:00
elegaanz (Migrado desde github.com) dejó un comentario
Copiar enlace

I didn't tested yet, but I left a few comments about the code itself.

I didn't tested yet, but I left a few comments about the code itself.
plume-front/src/editor.rs
elegaanz (Migrado desde github.com) comentado 2019-11-01 20:01:09 +00:00
Copiar enlace

Is the type hint really needed?

Is the type hint really needed?
elegaanz (Migrado desde github.com) comentado 2019-11-01 20:01:50 +00:00
Copiar enlace

Maybe this line should be removed ?

Maybe this line should be removed ?
elegaanz (Migrado desde github.com) comentado 2019-11-01 20:01:56 +00:00
Copiar enlace

This one too

This one too
elegaanz (Migrado desde github.com) comentado 2019-11-01 20:04:58 +00:00
Copiar enlace

You should use i18n! for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so.

i18n!(
    CATALOG,
    "Do you want to load the local autosave last edited at {}";
    Date::from_time(autosave_info.last_saved).to_date_string()
)
You should use `i18n!` for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so. ```rust i18n!( CATALOG, "Do you want to load the local autosave last edited at {}"; Date::from_time(autosave_info.last_saved).to_date_string() ) ```
elegaanz (Migrado desde github.com) comentado 2019-11-01 20:05:49 +00:00
Copiar enlace

Why does it need to be unsafe?

Why does it need to be `unsafe`?
epsilon-phase (Migrado desde github.com) revisó 2019-11-01 20:07:24 +00:00
plume-front/src/editor.rs
epsilon-phase (Migrado desde github.com) comentado 2019-11-01 20:07:24 +00:00
Copiar enlace

Oh, probably not

Oh, probably not
epsilon-phase (Migrado desde github.com) revisó 2019-11-01 20:09:54 +00:00
plume-front/src/editor.rs
epsilon-phase (Migrado desde github.com) comentado 2019-11-01 20:09:54 +00:00
Copiar enlace

Oh, it should probably just be unsafe on the lines that refer to the static mut

Oh, it should probably just be unsafe on the lines that refer to the `static mut`
elegaanz (Migrado desde github.com) revisó 2019-11-01 20:14:02 +00:00
plume-front/src/editor.rs
elegaanz (Migrado desde github.com) comentado 2019-11-01 20:14:02 +00:00
Copiar enlace

No, I don't know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.

No, I don't know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.
epsilon-phase (Migrado desde github.com) revisó 2019-11-01 20:19:29 +00:00
plume-front/src/editor.rs
epsilon-phase (Migrado desde github.com) comentado 2019-11-01 20:19:28 +00:00
Copiar enlace

That option looked off to us too tbh.. At least on its own
Maybe it'd be better to use a RefCell or something?

That option looked off to us too tbh.. At least on its own Maybe it'd be better to use a RefCell or something?
elegaanz (Migrado desde github.com) revisó 2019-11-01 20:22:01 +00:00
plume-front/src/editor.rs
elegaanz (Migrado desde github.com) comentado 2019-11-01 20:22:01 +00:00
Copiar enlace

Anything that will prevent having unsafe code is fine (not that it is really unsafe, we only have one thread when running in the browser).

Anything that will prevent having `unsafe` code is fine (not that it is really unsafe, we only have one thread when running in the browser).
epsilon-phase (Migrado desde github.com) revisó 2019-11-01 20:43:27 +00:00
plume-front/src/editor.rs
epsilon-phase (Migrado desde github.com) comentado 2019-11-01 20:43:27 +00:00
Copiar enlace

Didn't realize it was possible to do that with i18n!, that's nifty :)

Didn't realize it was possible to do that with `i18n!`, that's nifty :)
elegaanz (Migrado desde github.com) aprobó estos cambios 2019-11-02 14:14:22 +00:00
elegaanz (Migrado desde github.com) dejó un comentario
Copiar enlace

Works as expected, thank you!

Works as expected, thank you!
Inicie sesión para unirse a esta conversación.
Revisores
No hay revisores
elegaanz
Etiquetas
Limpiar etiquetas   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Sin etiquetas
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Limpiar Milestone
No hay elementos
Sin hito
Proyectos
Limpiar proyectos
No hay elementos
Ningún proyecto
Asignados
Limpiar asignados
Sin encargados
2 participantes
Notificaciones
Fecha límite
La fecha límite es inválida o está fuera de rango. Por favor utiliza el formato "aaaa-mm-dd".

Fecha límite no definida.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#688
No se ha proporcionado una descripción.
Eliminar rama "confirmation-autosave "

Eliminar una rama es permanente. Aunque la rama eliminada puede continuar existiendo durante un corto tiempo antes de que sea eliminada, en la mayoría de los casos NO PUEDE deshacerse. ¿Continuar?