Plume
/
Plume
8
16
Förgrening 22
Kod Ärenden 174 Pull-förfrågningar 8 Släpp 8 Wiki Aktiviteter

Etiketter Milstenar

Add autosaving to the editor #688

Sammanfogat
epsilon-phase sammanfogade 6 incheckningar från confirmation-autosave in i master 5 år sedan
Konversation 1 Incheckningar 6 Ändrade Filer 4
epsilon-phase kommenterad 5 år sedan (Migrerad från github.com)

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose

This should fix #686 Confirmation prior to navigating away is easy enough to add, but it'd be good to know if it's wanted first since this seems like it might serve the same purpose
codecov[bot] kommenterad 5 år sedan (Migrerad från github.com)

Codecov Report

Merging #688 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #688   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          72       72           
  Lines        9494     9494           
  Branches     2263     2263           
=======================================
  Hits         3736     3736           
  Misses       4702     4702           
  Partials     1056     1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=h1) Report > Merging [#688](https://codecov.io/gh/Plume-org/Plume/pull/688?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/865f372d5a9c0866c7ec5215afb69d2916740c07?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #688 +/- ## ======================================= Coverage 39.35% 39.35% ======================================= Files 72 72 Lines 9494 9494 Branches 2263 2263 ======================================= Hits 3736 3736 Misses 4702 4702 Partials 1056 1056 ```
trinity-1686a granskad av 5 år sedan
trinity-1686a lämnade en kommentar
Ägare

👀

:eyes:
plume-front/src/editor.rs
trinity-1686a kommenterad 5 år sedan
Ägare

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)

while content is probably the most annoying to loose, if we do a local save, we should as well save everything (including subtitle, tags...)
plume-front/src/editor.rs
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
trinity-1686a kommenterad 5 år sedan
Ägare

I guess set_interval does not exist? 😕

I guess set_interval does not exist? :confused:
epsilon-phase (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
epsilon-phase (Migrerad från github.com) kommenterad 5 år sedan

It doesn't look like it, oddly.

It doesn't look like it, oddly.
epsilon-phase (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
epsilon-phase (Migrerad från github.com) kommenterad 5 år sedan

True enough, easy enough to add too

True enough, easy enough to add too
epsilon-phase (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
@ -66,0 +212,4 @@
fn autosave_debounce() {
let timeout = &mut AUTOSAVE_TIMEOUT.lock().unwrap();
if let Some(timeout) = timeout.take() {
timeout.clear();
epsilon-phase (Migrerad från github.com) kommenterad 5 år sedan

Okay, works fine in the js!

Okay, works fine in the `js!`
elegaanz (Migrerad från github.com) granskad av 5 år sedan
elegaanz (Migrerad från github.com) lämnade en kommentar

I didn't tested yet, but I left a few comments about the code itself.

I didn't tested yet, but I left a few comments about the code itself.
plume-front/src/editor.rs
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

Is the type hint really needed?

Is the type hint really needed?
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

Maybe this line should be removed ?

Maybe this line should be removed ?
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

This one too

This one too
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

You should use i18n! for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so.

i18n!(
    CATALOG,
    "Do you want to load the local autosave last edited at {}";
    Date::from_time(autosave_info.last_saved).to_date_string()
)
You should use `i18n!` for formatting, to allow the date to be placed somewhere else in the sentence if translators need to do so. ```rust i18n!( CATALOG, "Do you want to load the local autosave last edited at {}"; Date::from_time(autosave_info.last_saved).to_date_string() ) ```
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

Why does it need to be unsafe?

Why does it need to be `unsafe`?
epsilon-phase (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
epsilon-phase (Migrerad från github.com) kommenterad 5 år sedan

Oh, probably not

Oh, probably not
epsilon-phase (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
epsilon-phase (Migrerad från github.com) kommenterad 5 år sedan

Oh, it should probably just be unsafe on the lines that refer to the static mut

Oh, it should probably just be unsafe on the lines that refer to the `static mut`
elegaanz (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

No, I don't know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.

No, I don't know much about unsafe, so maybe you are right and whole function should be. But also, I feel like there is a better way to do this, like going with lazy_static for instance.
epsilon-phase (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
epsilon-phase (Migrerad från github.com) kommenterad 5 år sedan

That option looked off to us too tbh.. At least on its own
Maybe it'd be better to use a RefCell or something?

That option looked off to us too tbh.. At least on its own Maybe it'd be better to use a RefCell or something?
elegaanz (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

Anything that will prevent having unsafe code is fine (not that it is really unsafe, we only have one thread when running in the browser).

Anything that will prevent having `unsafe` code is fine (not that it is really unsafe, we only have one thread when running in the browser).
epsilon-phase (Migrerad från github.com) granskad av 5 år sedan
plume-front/src/editor.rs
epsilon-phase (Migrerad från github.com) kommenterad 5 år sedan

Didn't realize it was possible to do that with i18n!, that's nifty :)

Didn't realize it was possible to do that with `i18n!`, that's nifty :)
elegaanz (Migrerad från github.com) godkände dessa ändringar 5 år sedan
elegaanz (Migrerad från github.com) lämnade en kommentar

Works as expected, thank you!

Works as expected, thank you!

Granskare

elegaanz
Pull-förfrågan har sammanfogats som c0469c69c1.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b confirmation-autosave master
git pull origin confirmation-autosave

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff confirmation-autosave
git push origin master
Logga in för att delta i denna konversation.
Granskare
Begär granskning
Inga granskare
elegaanz
Etiketter
Tillämpa etiketter
Rensa etiketter   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Ingen Etikett
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milsten
Ange milstolpe
Rensa milstenar
Inga objekt
Ingen Milsten
Tilldelade
Tilldela användare
Rensa tilldelade
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: Plume/Plume#688
Skriv Förhandsgranska
Laddar…
Avbryt
Spara
Det finns inget innehåll än.
Ta bort branch 'confirmation-autosave'

Borttagning utav en branch är permanent. Detta KAN INTE ångras. Vill du fortsätta?

Nej
Ja