Fix the navigation menu not opening on touch #690
No reviewers
Labels
No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#690
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes the issue of the mobile menu not reacting to touch, in cases where mouse clicking is not being simulated.
As you can see here,
add_event_listener
only takes one argument in Rust.However, I think replacing
|_: ClickEvent|
with|_: TouchEnd|
may work.The problem is that touchend is exclusive for iOS. Click event should still
probably stay for everything else...
On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez notifications@github.com wrote:
It seems to work on all mobile browsers: https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event#Browser_compatibility and we don't really care about desktop here I think, right?
Codecov Report
Ok, I've just modified it that way then.