Fix the navigation menu not opening on touch #690

Zusammengeführt

marek-lach hat 6 Commits von master nach master 2019-11-16 17:52:31 +00:00 zusammengeführt

marek-lach hat

2019-11-04 23:19:02 +00:00

kommentiert (Migriert von github.com)

Fixes the issue of the mobile menu not reacting to touch, in cases where mouse clicking is not being simulated.

elegaanz hat

2019-11-06 12:05:49 +00:00

kommentiert (Migriert von github.com)

As you can see here, add_event_listener only takes one argument in Rust.

However, I think replacing |_: ClickEvent| with |_: TouchEnd| may work.

As you can see [here](https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link), `add_event_listener` only takes one argument in Rust. However, I think replacing `|_: ClickEvent|` with `|_: TouchEnd|` may work.

marek-lach hat

2019-11-06 13:10:02 +00:00

kommentiert (Migriert von github.com)

The problem is that touchend is exclusive for iOS. Click event should still
probably stay for everything else...

On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez notifications@github.com wrote:

As you can see here
https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link,
add_event_listener only takes one argument in Rust.

However, I think replacing |: ClickEvent| with |: TouchEnd| may work.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Plume-org/Plume/pull/690?email_source=notifications&email_token=AK6JO6PMTLX7PJAWICWRN53QSKXKBA5CNFSM4JI3LRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGJZXA#issuecomment-550280412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK6JO6P37W6LS2U26ZM4KG3QSKXKBANCNFSM4JI3LRBQ
.

The problem is that touchend is exclusive for iOS. Click event should still probably stay for everything else... On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez <notifications@github.com> wrote: > As you can see here > <https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link>, > add_event_listener only takes one argument in Rust. > > However, I think replacing |_: ClickEvent| with |_: TouchEnd| may work. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/Plume-org/Plume/pull/690?email_source=notifications&email_token=AK6JO6PMTLX7PJAWICWRN53QSKXKBA5CNFSM4JI3LRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGJZXA#issuecomment-550280412>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AK6JO6P37W6LS2U26ZM4KG3QSKXKBANCNFSM4JI3LRBQ> > . >

elegaanz hat

2019-11-06 13:24:39 +00:00

kommentiert (Migriert von github.com)

It seems to work on all mobile browsers: https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event#Browser_compatibility and we don't really care about desktop here I think, right?

👍 1

codecov[bot] hat

2019-11-06 13:27:24 +00:00

kommentiert (Migriert von github.com)

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/690?src=pr&el=h1) Report > Merging [#690](https://codecov.io/gh/Plume-org/Plume/pull/690?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/f0846ff5465e3e28807570f0110437098f60efa1?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #690 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```

marek-lach hat

2019-11-06 13:37:50 +00:00

kommentiert (Migriert von github.com)

Ok, I've just modified it that way then.

👍 1

igalic (Migriert von github.com) hat die Änderungen 2019-11-16 16:11:40 +00:00 genehmigt

Anmelden, um an der Diskussion teilzunehmen.

Keine Reviewer

igalic