Fix the navigation menu not opening on touch #690

已合并
marek-lach 4 年前 将 6 次代码提交从 master 合并至 master
marek-lach 评论于 4 年前 (从 github.com 迁移)

Fixes the issue of the mobile menu not reacting to touch, in cases where mouse clicking is not being simulated.

Fixes the issue of the mobile menu not reacting to touch, in cases where mouse clicking is not being simulated.
elegaanz 评论于 4 年前 (从 github.com 迁移)

As you can see here, add_event_listener only takes one argument in Rust.

However, I think replacing |_: ClickEvent| with |_: TouchEnd| may work.

As you can see [here](https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link), `add_event_listener` only takes one argument in Rust. However, I think replacing `|_: ClickEvent|` with `|_: TouchEnd|` may work.
marek-lach 评论于 4 年前 (从 github.com 迁移)

The problem is that touchend is exclusive for iOS. Click event should still
probably stay for everything else...

On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez notifications@github.com wrote:

As you can see here
https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link,
add_event_listener only takes one argument in Rust.

However, I think replacing |: ClickEvent| with |: TouchEnd| may work.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Plume-org/Plume/pull/690?email_source=notifications&email_token=AK6JO6PMTLX7PJAWICWRN53QSKXKBA5CNFSM4JI3LRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGJZXA#issuecomment-550280412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK6JO6P37W6LS2U26ZM4KG3QSKXKBANCNFSM4JI3LRBQ
.

The problem is that touchend is exclusive for iOS. Click event should still probably stay for everything else... On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez <notifications@github.com> wrote: > As you can see here > <https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link>, > add_event_listener only takes one argument in Rust. > > However, I think replacing |_: ClickEvent| with |_: TouchEnd| may work. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/Plume-org/Plume/pull/690?email_source=notifications&email_token=AK6JO6PMTLX7PJAWICWRN53QSKXKBA5CNFSM4JI3LRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGJZXA#issuecomment-550280412>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AK6JO6P37W6LS2U26ZM4KG3QSKXKBANCNFSM4JI3LRBQ> > . >
elegaanz 评论于 4 年前 (从 github.com 迁移)

It seems to work on all mobile browsers: https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event#Browser_compatibility and we don't really care about desktop here I think, right?

It seems to work on all mobile browsers: https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event#Browser_compatibility and we don't really care about desktop here I think, right?
codecov[bot] 评论于 4 年前 (从 github.com 迁移)

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/690?src=pr&el=h1) Report > Merging [#690](https://codecov.io/gh/Plume-org/Plume/pull/690?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/f0846ff5465e3e28807570f0110437098f60efa1?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #690 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```
marek-lach 评论于 4 年前 (从 github.com 迁移)

Ok, I've just modified it that way then.

Ok, I've just modified it that way then.
igalic (从 github.com 迁移)4 年前 批准此合并请求

评审人

该合并请求已作为 c66ef5f85d 被合并。
你也可以查看 命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。
git checkout -b master master
git pull origin master

第二步:

合并变更并更新到 Forgejo 上
git checkout master
git merge --no-ff master
git push origin master
登录 并参与到对话中。
无审核者
未选择里程碑
未指派成员
1 名参与者
通知
到期时间
到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

参考:Plume/Plume#690
正在加载...
这个人很懒,什么都没留下。