Fix the navigation menu not opening on touch #690
沒有審核者
標籤
未選擇標籤
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
沒有里程碑
未選擇專案
沒有負責人
1 位參與者
通知
截止日期
未設定截止日期。
先決條件
未設定先決條件。
參考: Plume/Plume#690
載入中…
新增表格
新增問題並參考
沒有提供敘述。
刪除分支「master」
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes the issue of the mobile menu not reacting to touch, in cases where mouse clicking is not being simulated.
As you can see here,
add_event_listener
only takes one argument in Rust.However, I think replacing
|_: ClickEvent|
with|_: TouchEnd|
may work.The problem is that touchend is exclusive for iOS. Click event should still
probably stay for everything else...
On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez notifications@github.com wrote:
It seems to work on all mobile browsers: https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event#Browser_compatibility and we don't really care about desktop here I think, right?
Codecov Report
Ok, I've just modified it that way then.