Fix the navigation menu not opening on touch #690

已合併
marek-lach 2019-11-16 17:52:31 +00:00master 合併了 6 個提交至 master
marek-lach 已留言 2019-11-04 23:19:02 +00:00 (已從 github.com 遷移)

Fixes the issue of the mobile menu not reacting to touch, in cases where mouse clicking is not being simulated.

Fixes the issue of the mobile menu not reacting to touch, in cases where mouse clicking is not being simulated.
elegaanz 已留言 2019-11-06 12:05:49 +00:00 (已從 github.com 遷移)

As you can see here, add_event_listener only takes one argument in Rust.

However, I think replacing |_: ClickEvent| with |_: TouchEnd| may work.

As you can see [here](https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link), `add_event_listener` only takes one argument in Rust. However, I think replacing `|_: ClickEvent|` with `|_: TouchEnd|` may work.
marek-lach 已留言 2019-11-06 13:10:02 +00:00 (已從 github.com 遷移)

The problem is that touchend is exclusive for iOS. Click event should still
probably stay for everything else...

On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez notifications@github.com wrote:

As you can see here
https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link,
add_event_listener only takes one argument in Rust.

However, I think replacing |: ClickEvent| with |: TouchEnd| may work.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Plume-org/Plume/pull/690?email_source=notifications&email_token=AK6JO6PMTLX7PJAWICWRN53QSKXKBA5CNFSM4JI3LRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGJZXA#issuecomment-550280412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK6JO6P37W6LS2U26ZM4KG3QSKXKBANCNFSM4JI3LRBQ
.

The problem is that touchend is exclusive for iOS. Click event should still probably stay for everything else... On Wed, Nov 6, 2019 at 1:05 PM Ana Gelez <notifications@github.com> wrote: > As you can see here > <https://circleci.com/gh/Plume-org/Plume/9186?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link>, > add_event_listener only takes one argument in Rust. > > However, I think replacing |_: ClickEvent| with |_: TouchEnd| may work. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/Plume-org/Plume/pull/690?email_source=notifications&email_token=AK6JO6PMTLX7PJAWICWRN53QSKXKBA5CNFSM4JI3LRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDGJZXA#issuecomment-550280412>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AK6JO6P37W6LS2U26ZM4KG3QSKXKBANCNFSM4JI3LRBQ> > . >
elegaanz 已留言 2019-11-06 13:24:39 +00:00 (已從 github.com 遷移)

It seems to work on all mobile browsers: https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event#Browser_compatibility and we don't really care about desktop here I think, right?

It seems to work on all mobile browsers: https://developer.mozilla.org/en-US/docs/Web/API/Document/touchend_event#Browser_compatibility and we don't really care about desktop here I think, right?
codecov[bot] 已留言 2019-11-06 13:27:24 +00:00 (已從 github.com 遷移)

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/690?src=pr&el=h1) Report > Merging [#690](https://codecov.io/gh/Plume-org/Plume/pull/690?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/f0846ff5465e3e28807570f0110437098f60efa1?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #690 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```
marek-lach 已留言 2019-11-06 13:37:50 +00:00 (已從 github.com 遷移)

Ok, I've just modified it that way then.

Ok, I've just modified it that way then.
igalic (已從 github.com 遷移) 核可了這些變更 2019-11-16 16:11:40 +00:00
登入 才能加入這對話。
沒有審核者
沒有里程碑
未選擇專案
沒有負責人
1 位參與者
通知
截止日期
截止日期無效或超出範圍,請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: Plume/Plume#690
沒有提供敘述。