make search items optional #693

Merged

Plume_migration_agent merged 2 commits from search-optional into master

2019-11-10 14:37:52 +00:00

trinity-1686a commented

2019-11-06 21:40:55 +00:00

Owner

cf https://github.com/Plume-org/Plume/issues/692#issuecomment-550224029

codecov[bot] commented

2019-11-06 21:59:09 +00:00

(Migrated from github.com)

Codecov Report

Merging #693 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/693?src=pr&el=h1) Report > Merging [#693](https://codecov.io/gh/Plume-org/Plume/pull/693?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/f0846ff5465e3e28807570f0110437098f60efa1?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #693 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```

elegaanz (Migrated from github.com) reviewed 2019-11-07 11:51:52 +00:00

elegaanz (Migrated from github.com) left a comment

There is an indentation issue, but otherwise 👌

There is an indentation issue, but otherwise :ok_hand:

elegaanz (Migrated from github.com) approved these changes 2019-11-10 14:37:46 +00:00

elegaanz (Migrated from github.com) left a comment

Thanks!

No reviewers

elegaanz

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#693

No description provided.

Rows
Columns