"Manually" (with SQL) fill the default timelines #696

2019-11-15T17:21:09Z

elegaanz commented

2019-11-15 17:21:09 +00:00

(Migrated from github.com)

Fixes #692

Adding a plm command was too much refactoring (because the timelines need a PlumeRocket while plm only has a Connection), so I didn't do it.

Fixes #692 Adding a plm command was too much refactoring (because the timelines need a `PlumeRocket` while `plm` only has a `Connection`), so I didn't do it.

codecov[bot] commented

2019-11-15 17:41:05 +00:00

(Migrated from github.com)

Codecov Report

Merging #696 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   39.25%   39.32%   +0.07%     
==========================================
  Files          72       72              
  Lines        9498     9498              
  Branches     2265     2265              
==========================================
+ Hits         3728     3735       +7     
+ Misses       4713     4706       -7     
  Partials     1057     1057

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/696?src=pr&el=h1) Report > Merging [#696](https://codecov.io/gh/Plume-org/Plume/pull/696?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c484ca6afe29a2d6c062b99df22485fcbc57cb9b?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #696 +/- ## ========================================== + Coverage 39.25% 39.32% +0.07% ========================================== Files 72 72 Lines 9498 9498 Branches 2265 2265 ========================================== + Hits 3728 3735 +7 + Misses 4713 4706 -7 Partials 1057 1057 ```

igalic (Migrated from github.com) requested changes 2019-11-16 16:05:26 +00:00

igalic (Migrated from github.com) left a comment

can you please explain the difference between the two queries, and why they are (both) necessary

igalic (Migrated from github.com) reviewed 2019-11-16 19:44:04 +00:00

igalic (Migrated from github.com) left a comment

🙋

migrations/postgres/2019-06-24-101212_use_timelines_for_feed/up.sql

					
				@ -18,0 +22,4 @@

				INSERT INTO timeline (post_id, timeline_id) SELECT posts.id, (SELECT id FROM timeline_definition WHERE query = 'local' LIMIT 1) FROM blogs INNER JOIN posts ON posts.blog_id = blogs.id WHERE blogs.instance_id = 1;

				-- Add all articles to the the federated timeline

				INSERT INTO timeline (post_id, timeline_id) SELECT posts.id, (SELECT id FROM timeline_definition WHERE query = 'all' LIMIT 1) FROM posts;

igalic (Migrated from github.com) commented

2019-11-16 19:43:47 +00:00

so how come this one isn't enough?

elegaanz (Migrated from github.com) reviewed 2019-12-09 18:27:13 +00:00

migrations/postgres/2019-06-24-101212_use_timelines_for_feed/up.sql

					
				@ -18,0 +22,4 @@

				INSERT INTO timeline (post_id, timeline_id) SELECT posts.id, (SELECT id FROM timeline_definition WHERE query = 'local' LIMIT 1) FROM blogs INNER JOIN posts ON posts.blog_id = blogs.id WHERE blogs.instance_id = 1;

				-- Add all articles to the the federated timeline

				INSERT INTO timeline (post_id, timeline_id) SELECT posts.id, (SELECT id FROM timeline_definition WHERE query = 'all' LIMIT 1) FROM posts;

elegaanz (Migrated from github.com) commented

2019-12-09 18:27:13 +00:00

These are not the same timelines/feeds, we need to add posts to both of them (do you want me to explain that in a comment too?)

elegaanz commented

2019-12-14 20:10:18 +00:00

(Migrated from github.com)

Superseded by #704

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

igalic

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#696