#700 Fix #637 : Markdown footnotes

Merged
papey merged 2 commits from fix-markdown-notes into master 1 year ago
papey commented 1 year ago (Migrated from github.com)

Here is fix for issue #637 that :

  • Ensure footnotes classes are not filtered by html sanitizer
  • Add some footnote style rules

An example of footnotes using this fix :

Markdown :

Here is something[^a]


Here is another thing[^b]

[^a]: something

[^b]: another thing

Footnotes rendeering

Note that there is some cpull-markdown related syntax : a carriage return is needed between each note definition

Here is fix for issue #637 that : - Ensure footnotes classes are not filtered by html sanitizer - Add some footnote style rules An example of footnotes using this fix : **Markdown :** ```md Here is something[^a] Here is another thing[^b] [^a]: something [^b]: another thing ``` ![Footnotes rendeering](https://user-images.githubusercontent.com/17273325/69247036-0d144700-0baa-11ea-83bd-bbd9fa6564c4.png) Note that there is some cpull-markdown related syntax : **a carriage return is needed between each note definition**
papey commented 1 year ago (Migrated from github.com)
Owner

Note that back reference are not supported (yet) by cpull-markdown : https://github.com/raphlinus/pulldown-cmark/issues/142

Note that back reference are not supported (yet) by cpull-markdown : https://github.com/raphlinus/pulldown-cmark/issues/142
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/700?src=pr&el=h1) Report > Merging [#700](https://codecov.io/gh/Plume-org/Plume/pull/700?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/7f296b2ef2fe17482f24fe84b4ecb3ae0947601f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #700 +/- ## ======================================= Coverage 39.25% 39.25% ======================================= Files 72 72 Lines 9498 9498 Branches 2265 2265 ======================================= Hits 3728 3728 Misses 4713 4713 Partials 1057 1057 ```
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Thanks!

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 3bd2305115.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.