[wip] use Authorized fetch #723

Closed

epsilon-phase wants to merge 2 commits from epsilon-phase/authorized-fetch into master

epsilon-phase commented (Migrated from github.com)

The current solution is rather hacky, but it is the best we can figure out without more input and guidance. The ideal solution is to have a quasi actor that can sign these requests and be transparent to the user. As of now it merely fetches the first local user that comes to hand and signs the request with their information.

Many activitypub servers are starting to enable Mastodon style authorized fetch for security reasons. As plume does not sign the user fetches, this means it is not possible to fetch actor information from these servers The current solution is rather hacky, but it is the best we can figure out without more input and guidance. The ideal solution is to have a quasi actor that can sign these requests and be transparent to the user. As of now it merely fetches the first local user that comes to hand and signs the request with their information.

👍 1

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #723 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   39.13%   39.09%   -0.05%     
==========================================
  Files          73       73              
  Lines        9684     9695      +11     
  Branches     2315     2321       +6     
==========================================
  Hits         3790     3790              
- Misses       4807     4818      +11     
  Partials     1087     1087

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/723?src=pr&el=h1) Report > Merging [#723](https://codecov.io/gh/Plume-org/Plume/pull/723?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/f3c05dae62ffe6cf73b74e3cbf7be1116be8760c?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #723 +/- ## ========================================== - Coverage 39.13% 39.09% -0.05% ========================================== Files 73 73 Lines 9684 9695 +11 Branches 2315 2321 +6 ========================================== Hits 3790 3790 - Misses 4807 4818 +11 Partials 1087 1087 ```

KitaitiMakoto closed this pull request

This pull request cannot be reopened because the branch was deleted.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b epsilon-phase/authorized-fetch master

git pull origin epsilon-phase/authorized-fetch

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff epsilon-phase/authorized-fetch

git push origin master

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

[wip] use Authorized fetch #723

Codecov Report

Step 1:

Step 2: