Update compiler #725

Merged

Plume_migration_agent merged 7 commits from update-compiler into master

2020-01-19 11:52:32 +00:00

trinity-1686a commented

2020-01-18 15:13:08 +00:00

Owner

update the compiler, and fix deprecation warnings & assimilated

❤️ 2 🎉 2

trinity-1686a commented

2020-01-18 15:25:07 +00:00

Author

Owner

hum, it's broken when using ructe 0.6.4, but we get deprecation warnings (hard errors due to -D all when using clippy) when using an older version (0.6.2) 😕

hum, it's broken when using ructe 0.6.4, but we get deprecation warnings (hard errors due to `-D all` when using clippy) when using an older version (0.6.2) :confused:

codecov[bot] commented

2020-01-18 18:25:05 +00:00

(Migrated from github.com)

Codecov Report

Merging #725 into master will increase coverage by 0.02%.
The diff coverage is 34%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   39.12%   39.15%   +0.02%     
==========================================
  Files          73       73              
  Lines        9686     9650      -36     
  Branches     2315     2184     -131     
==========================================
- Hits         3790     3778      -12     
- Misses       4809     4820      +11     
+ Partials     1087     1052      -35

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/725?src=pr&el=h1) Report > Merging [#725](https://codecov.io/gh/Plume-org/Plume/pull/725?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/72464fb4283d252e345c7a416530384e60bc2d58?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `34%`. ```diff @@ Coverage Diff @@ ## master #725 +/- ## ========================================== + Coverage 39.12% 39.15% +0.02% ========================================== Files 73 73 Lines 9686 9650 -36 Branches 2315 2184 -131 ========================================== - Hits 3790 3778 -12 - Misses 4809 4820 +11 + Partials 1087 1052 -35 ```

elegaanz (Migrated from github.com) approved these changes 2020-01-19 11:52:19 +00:00

elegaanz (Migrated from github.com) left a comment

If it compiles, it is OK I guess. I read the code quickly, and it seems good. LGTM! And thank you :)