#726 Rust 2018!

Merged
elegaanz merged 1 commits from rust-2018 into master 10 months ago
elegaanz commented 10 months ago (Migrated from github.com)

Finally!

Fixes #423 btw

Finally! Fixes #423 btw
codecov[bot] commented 10 months ago (Migrated from github.com)
Owner

Codecov Report

Merging #726 into master will increase coverage by 0.02%.
The diff coverage is 38.23%.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   39.15%   39.17%   +0.02%     
==========================================
  Files          73       73              
  Lines        9650     9653       +3     
  Branches     2184     2183       -1     
==========================================
+ Hits         3778     3782       +4     
+ Misses       4820     4819       -1     
  Partials     1052     1052
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/726?src=pr&el=h1) Report > Merging [#726](https://codecov.io/gh/Plume-org/Plume/pull/726?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/3663bffe5c4760afdda8b739ecd58a5a191dde6a?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `38.23%`. ```diff @@ Coverage Diff @@ ## master #726 +/- ## ========================================== + Coverage 39.15% 39.17% +0.02% ========================================== Files 73 73 Lines 9650 9653 +3 Branches 2184 2183 -1 ========================================== + Hits 3778 3782 +4 + Misses 4820 4819 -1 Partials 1052 1052 ```
igalic (Migrated from github.com) approved these changes 10 months ago
igalic (Migrated from github.com) left a comment

👀

Plume_migration_agent commented 10 months ago

how are we removing so many crates here?

how are we removing so many crates here?
Plume_migration_agent commented 10 months ago

again? what’s happening here?
is this a feature of 2018?

again? what's happening here? is this a feature of 2018?
trinity-1686a reviewed 10 months ago
trinity-1686a commented 10 months ago

extern crate is no longer mandatory on 2018, except when you want to call #[macro_use] on it. It is also possible to include macros by path like anything else to not use #[macro_use], so it’s possible to have 0 extern crate but a lot of actual dependencies in Cargo.toml

`extern crate` is no longer mandatory on 2018, except when you want to call `#[macro_use]` on it. It is also possible to include macros by path like anything else to not use `#[macro_use]`, so it's possible to have 0 extern crate but a lot of actual dependencies in Cargo.toml
kiwii referenced this issue from a commit 3 months ago

Reviewers

Plume_migration_agent approved these changes 10 months ago
The pull request has been merged as 5f8d6b8e0e.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.