Rust 2018! #726

Zusammengeführt

elegaanz hat 1 Commit von rust-2018 nach master 2020-01-21 06:02:04 +00:00 zusammengeführt

elegaanz hat

2020-01-20 20:07:01 +00:00

kommentiert (Migriert von github.com)

Finally!

Fixes #423 btw

Finally! Fixes #423 btw

codecov[bot] hat

2020-01-20 20:39:07 +00:00

kommentiert (Migriert von github.com)

Codecov Report

Merging #726 into master will increase coverage by 0.02%.
The diff coverage is 38.23%.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   39.15%   39.17%   +0.02%     
==========================================
  Files          73       73              
  Lines        9650     9653       +3     
  Branches     2184     2183       -1     
==========================================
+ Hits         3778     3782       +4     
+ Misses       4820     4819       -1     
  Partials     1052     1052

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/726?src=pr&el=h1) Report > Merging [#726](https://codecov.io/gh/Plume-org/Plume/pull/726?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/3663bffe5c4760afdda8b739ecd58a5a191dde6a?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `38.23%`. ```diff @@ Coverage Diff @@ ## master #726 +/- ## ========================================== + Coverage 39.15% 39.17% +0.02% ========================================== Files 73 73 Lines 9650 9653 +3 Branches 2184 2183 -1 ========================================== + Hits 3778 3782 +4 + Misses 4820 4819 -1 Partials 1052 1052 ```

igalic (Migriert von github.com) hat die Änderungen 2020-01-20 21:13:15 +00:00 genehmigt

igalic (Migriert von github.com) hat einen Kommentar hinterlassen

👀️

plume-common/src/lib.rs

igalic (Migriert von github.com) hat

2020-01-20 20:43:45 +00:00

kommentiert

how are we removing so many crates here?

src/main.rs

igalic (Migriert von github.com) hat

2020-01-20 21:08:59 +00:00

kommentiert

again? what's happening here?
is this a feature of 2018?

again? what's happening here? is this a feature of 2018?

trinity-1686a hat 2020-01-20 23:00:01 +00:00 gereviewt

plume-common/src/lib.rs

trinity-1686a hat

2020-01-20 23:00:01 +00:00

kommentiert

Besitzer

extern crate is no longer mandatory on 2018, except when you want to call #[macro_use] on it. It is also possible to include macros by path like anything else to not use #[macro_use], so it's possible to have 0 extern crate but a lot of actual dependencies in Cargo.toml

`extern crate` is no longer mandatory on 2018, except when you want to call `#[macro_use]` on it. It is also possible to include macros by path like anything else to not use `#[macro_use]`, so it's possible to have 0 extern crate but a lot of actual dependencies in Cargo.toml