Go async #730

Open
igalic wants to merge 46 commits from go/async into master
igalic commented 2 years ago (Migrated from github.com)
Owner

update rocket and its dependencies to their async branch.
update our code to use rocket's async APIs

update rocket and its dependencies to their `async` branch. update our code to use rocket's async APIs
codecov[bot] commented 2 years ago (Migrated from github.com)
Owner

Codecov Report

Merging #730 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   39.08%   39.11%   +0.03%     
==========================================
  Files          73       73              
  Lines        9736     9643      -93     
  Branches     2227     2183      -44     
==========================================
- Hits         3805     3772      -33     
+ Misses       4879     4819      -60     
  Partials     1052     1052              
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/730?src=pr&el=h1) Report > Merging [#730](https://codecov.io/gh/Plume-org/Plume/pull/730?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/ef70cb93e6d9457355bce4f6dae485c700bb07c6&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #730 +/- ## ========================================== + Coverage 39.08% 39.11% +0.03% ========================================== Files 73 73 Lines 9736 9643 -93 Branches 2227 2183 -44 ========================================== - Hits 3805 3772 -33 + Misses 4879 4819 -60 Partials 1052 1052 ```
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) commented 1 year ago
Poster
Owner

this std::fs::read could (should?) be async.

this std::fs::read could (should?) be async.
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) commented 1 year ago
Owner

It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?

It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?
This pull request has changes conflicting with the target branch.
Cargo.lock
Cargo.toml
plume-models/Cargo.toml
src/main.rs
src/routes/posts.rs
src/routes/user.rs
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.