New Pull Request

#730 Go async

Open

igalic wants to merge 46 commits from go/async into master

update rocket and its dependencies to their async branch.
update our code to use rocket’s async APIs

👍 1

Codecov Report

Merging #730 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   39.08%   39.11%   +0.03%     
==========================================
  Files          73       73              
  Lines        9736     9643      -93     
  Branches     2227     2183      -44     
==========================================
- Hits         3805     3772      -33     
+ Misses       4879     4819      -60     
  Partials     1052     1052

igalic (Migrated from github.com) reviewed 1 year ago

src/routes/mod.rs

Plume_migration_agent commented 1 year ago

this std::fs::read could (should?) be async.

elegaanz (Migrated from github.com) reviewed 1 year ago

src/routes/mod.rs

Plume_migration_agent commented 1 year ago

It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?

igalic referenced this pull request 9 months ago

[Refactoring] Move DbConn out PlumeRocket #797

This pull request has changes conflicting with the target branch.

Cargo.lock

Cargo.toml

plume-models/Cargo.toml

src/main.rs

src/routes/posts.rs

src/routes/user.rs

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.