Plume
/
Plume
5
12
Fork 12
Code Issues 152 Pull Requests 11 Releases 5 Wiki Activity
Labels Milestones
New Pull Request

Go async #730

Open
igalic wants to merge 46 commits from go/async into master
Conversation 1 Commits 46 Files Changed 48
igalic commented 2 years ago (Migrated from github.com)
Owner

update rocket and its dependencies to their async branch.
update our code to use rocket's async APIs

update rocket and its dependencies to their `async` branch. update our code to use rocket's async APIs
👍 1
codecov[bot] commented 2 years ago (Migrated from github.com)
Owner

Codecov Report

Merging #730 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   39.08%   39.11%   +0.03%     
==========================================
  Files          73       73              
  Lines        9736     9643      -93     
  Branches     2227     2183      -44     
==========================================
- Hits         3805     3772      -33     
+ Misses       4879     4819      -60     
  Partials     1052     1052
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/730?src=pr&el=h1) Report > Merging [#730](https://codecov.io/gh/Plume-org/Plume/pull/730?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/ef70cb93e6d9457355bce4f6dae485c700bb07c6&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #730 +/- ## ========================================== + Coverage 39.08% 39.11% +0.03% ========================================== Files 73 73 Lines 9736 9643 -93 Branches 2227 2183 -44 ========================================== - Hits 3805 3772 -33 + Misses 4879 4819 -60 Partials 1052 1052 ```
igalic (Migrated from github.com) reviewed 1 year ago
src/routes/mod.rs
igalic (Migrated from github.com) commented 1 year ago
Poster
Owner

this std::fs::read could (should?) be async.

this std::fs::read could (should?) be async.
elegaanz (Migrated from github.com) reviewed 1 year ago
src/routes/mod.rs
elegaanz (Migrated from github.com) commented 1 year ago
Owner

It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?

It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?
This pull request has changes conflicting with the target branch.
Cargo.lock
Cargo.toml
plume-models/Cargo.toml
src/main.rs
src/routes/posts.rs
src/routes/user.rs
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label A: API A: Backend A: Federation A: Front-End A: I18N A: Meta A: Security Build C: Bug C: Discussion C: Enhancement C: Feature Compatibility Dependency Design Documentation Good first issue Help welcome Mobile Rendering S: Blocked S: Duplicate S: Incomplete S: Instance specific S: Invalid S: Needs Voting/Discussion S: Ready for review Suggestion S: Voted on Loomio S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'go/async'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes