Go async #730

Suljettu
igalic haluaa yhdistää 46 committia lähteestä go/async kohteeseen master
igalic kommentoi 4 vuotta sitten (Migrated from github.com)

update rocket and its dependencies to their async branch.
update our code to use rocket's async APIs

update rocket and its dependencies to their `async` branch. update our code to use rocket's async APIs
codecov[bot] kommentoi 4 vuotta sitten (Migrated from github.com)

Codecov Report

Merging #730 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   39.08%   39.11%   +0.03%     
==========================================
  Files          73       73              
  Lines        9736     9643      -93     
  Branches     2227     2183      -44     
==========================================
- Hits         3805     3772      -33     
+ Misses       4879     4819      -60     
  Partials     1052     1052              
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/730?src=pr&el=h1) Report > Merging [#730](https://codecov.io/gh/Plume-org/Plume/pull/730?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/ef70cb93e6d9457355bce4f6dae485c700bb07c6&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## master #730 +/- ## ========================================== + Coverage 39.08% 39.11% +0.03% ========================================== Files 73 73 Lines 9736 9643 -93 Branches 2227 2183 -44 ========================================== - Hits 3805 3772 -33 + Misses 4879 4819 -60 Partials 1052 1052 ```
igalic (Migrated from github.com) reviewed 4 vuotta sitten
igalic (Migrated from github.com) kommentoi 4 vuotta sitten

this std::fs::read could (should?) be async.

this std::fs::read could (should?) be async.
elegaanz (Migrated from github.com) reviewed 4 vuotta sitten
elegaanz (Migrated from github.com) kommentoi 4 vuotta sitten

It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?

It could with something like async-std, yes. But maybe add a todo and leave it for a future PR?
KitaitiMakoto closed this pull request 3 vuotta sitten
This pull request cannot be reopened because the branch was deleted.
You can also view command line instructions.

Vaihe 1:

From your project repository, check out a new branch and test the changes.
git checkout -b go/async master
git pull origin go/async

Vaihe 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff go/async
git push origin master
Sign in to join this conversation.
No reviewers
Ei merkkipaalua
Ei käsittelijää
1 osallistujaa
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Reference: Plume/Plume#730
Ladataan…
Sisältöä ei vielä ole.