Plume
/
Plume
8
16
Fork 22
Code Issues 174 Pull Requests 8 Releases 8 Wiki Activity

Labels Milestones

snap: Fix build process for Tier 2 platforms #732

Closed
RAOF wants to merge 1 commits from RAOF/fix-arm64-build into master
pull from: RAOF/fix-arm64-build
merge into: Plume:master
Conversation 1 Commits 1 Files Changed 1
RAOF commented 4 years ago (Migrated from github.com)

Unfortunately this only actually fixes the build for arm64;
it seems that we hit various bugs in Rust on ppc64 and armhf.

Unfortunately this only actually *fixes* the build for arm64; it seems that we hit various bugs in Rust on ppc64 and armhf.
igalic (Migrated from github.com) reviewed 4 years ago
snap/snapcraft.yaml
@ -37,3 +35,4 @@
- lld-9
override-build: |
snapcraftctl set-version $(git describe --tags)
export PATH=$PATH:$HOME/.cargo/bin
igalic (Migrated from github.com) commented 4 years ago

maybe we should get rid of these dependencies again, so we can have broader platform support

maybe we should get rid of these dependencies again, so we can have broader platform support
codecov[bot] commented 4 years ago (Migrated from github.com)

Codecov Report

Merging #732 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   39.16%   39.17%   +0.01%     
==========================================
  Files          73       73              
  Lines        9653     9653              
  Branches     2183     2183              
==========================================
+ Hits         3781     3782       +1     
  Misses       4819     4819              
+ Partials     1053     1052       -1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/732?src=pr&el=h1) Report > Merging [#732](https://codecov.io/gh/Plume-org/Plume/pull/732?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/2a58835f9291729076dc06febf050e47e08d73c1?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #732 +/- ## ========================================== + Coverage 39.16% 39.17% +0.01% ========================================== Files 73 73 Lines 9653 9653 Branches 2183 2183 ========================================== + Hits 3781 3782 +1 Misses 4819 4819 + Partials 1053 1052 -1 ```
RAOF (Migrated from github.com) reviewed 4 years ago
snap/snapcraft.yaml
@ -37,3 +35,4 @@
- lld-9
override-build: |
snapcraftctl set-version $(git describe --tags)
export PATH=$PATH:$HOME/.cargo/bin
RAOF (Migrated from github.com) commented 4 years ago

These actuality exist everywhere (on Linux); I just dropped the (attempted) “only install lld on tier 2 platforms” logic.

With lld-9 the build failures on ppc64 and armhf are elsewhere.

These actuality exist everywhere (on Linux); I just dropped the (attempted) “*only* install lld on tier 2 platforms” logic. With lld-9 the build failures on ppc64 and armhf are elsewhere.
KitaitiMakoto closed this pull request 3 years ago
This pull request cannot be reopened because the branch was deleted.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b RAOF/fix-arm64-build master
git pull origin RAOF/fix-arm64-build

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff RAOF/fix-arm64-build
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#732
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'RAOF/fix-arm64-build'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes