snap: Fix build process for Tier 2 platforms #732

KitaitiMakoto · 2020-01-24T07:03:56Z

RAOF commented

2020-01-24 07:03:56 +00:00

(Migrated from github.com)

Unfortunately this only actually fixes the build for arm64;
it seems that we hit various bugs in Rust on ppc64 and armhf.

Unfortunately this only actually *fixes* the build for arm64; it seems that we hit various bugs in Rust on ppc64 and armhf.

igalic (Migrated from github.com) reviewed 2020-01-24 07:24:45 +00:00

snap/snapcraft.yaml

					
				@ -37,3 +35,4 @@

				      - lld-9

				    override-build: |

				      snapcraftctl set-version $(git describe --tags)

				      export PATH=$PATH:$HOME/.cargo/bin

igalic (Migrated from github.com) commented

2020-01-24 07:23:54 +00:00

maybe we should get rid of these dependencies again, so we can have broader platform support

codecov[bot] commented

2020-01-24 07:30:47 +00:00

(Migrated from github.com)

Codecov Report

Merging #732 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   39.16%   39.17%   +0.01%     
==========================================
  Files          73       73              
  Lines        9653     9653              
  Branches     2183     2183              
==========================================
+ Hits         3781     3782       +1     
  Misses       4819     4819              
+ Partials     1053     1052       -1

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/732?src=pr&el=h1) Report > Merging [#732](https://codecov.io/gh/Plume-org/Plume/pull/732?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/2a58835f9291729076dc06febf050e47e08d73c1?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #732 +/- ## ========================================== + Coverage 39.16% 39.17% +0.01% ========================================== Files 73 73 Lines 9653 9653 Branches 2183 2183 ========================================== + Hits 3781 3782 +1 Misses 4819 4819 + Partials 1053 1052 -1 ```

RAOF (Migrated from github.com) reviewed 2020-01-24 11:22:38 +00:00

snap/snapcraft.yaml

					
				@ -37,3 +35,4 @@

				      - lld-9

				    override-build: |

				      snapcraftctl set-version $(git describe --tags)

				      export PATH=$PATH:$HOME/.cargo/bin

RAOF (Migrated from github.com) commented

2020-01-24 11:22:38 +00:00

These actuality exist everywhere (on Linux); I just dropped the (attempted) “only install lld on tier 2 platforms” logic.

With lld-9 the build failures on ppc64 and armhf are elsewhere.

These actuality exist everywhere (on Linux); I just dropped the (attempted) “*only* install lld on tier 2 platforms” logic. With lld-9 the build failures on ppc64 and armhf are elsewhere.

KitaitiMakoto closed this pull request

2021-09-05 04:50:49 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#732

Rows
Columns