Codecov Report

Merging #732 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   39.16%   39.17%   +0.01%     
==========================================
  Files          73       73              
  Lines        9653     9653              
  Branches     2183     2183              
==========================================
+ Hits         3781     3782       +1     
  Misses       4819     4819              
+ Partials     1053     1052       -1

Unfortunately this only actually fixes the build for arm64;
it seems that we hit various bugs in Rust on ppc64 and armhf.

igalic (Migrated from github.com) reviewed 10 months ago

snap/snapcraft.yaml

												
			@@ -37,3 +35,4 @@
		
			      - lld-9
		
			    override-build: |
		
			      snapcraftctl set-version $(git describe --tags)
		
			      export PATH=$PATH:$HOME/.cargo/bin

Plume_migration_agent commented 10 months ago

maybe we should get rid of these dependencies again, so we can have broader platform support

RAOF (Migrated from github.com) reviewed 10 months ago

These actuality exist everywhere (on Linux); I just dropped the (attempted) “only install lld on tier 2 platforms” logic.

With lld-9 the build failures on ppc64 and armhf are elsewhere.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

This branch is out-of-date with the base branch

#732 snap: Fix build process for Tier 2 platforms

Codecov Report