#741 Fixed #734 , passowrds are now hidden on the remote_interact pages

Merged
ksteimel merged 2 commits from master into master 7 months ago
ksteimel commented 9 months ago (Migrated from github.com)

This is a quick fix to remove visible passwords on the remote_interact pages.

This is a quick fix to remove visible passwords on the remote_interact pages.
codecov[bot] commented 9 months ago (Migrated from github.com)
Owner

Codecov Report

Merging #741 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
- Coverage   39.16%   38.98%   -0.19%     
==========================================
  Files          73       73              
  Lines        9653     9699      +46     
  Branches     2183     2229      +46     
==========================================
  Hits         3781     3781              
+ Misses       4819     4788      -31     
- Partials     1053     1130      +77     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/741?src=pr&el=h1) Report > Merging [#741](https://codecov.io/gh/Plume-org/Plume/pull/741?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/02c528cae4385883d13bfff891d1656613d24edd&el=desc) will **decrease** coverage by `0.18%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #741 +/- ## ========================================== - Coverage 39.16% 38.98% -0.19% ========================================== Files 73 73 Lines 9653 9699 +46 Branches 2183 2229 +46 ========================================== Hits 3781 3781 + Misses 4819 4788 -31 - Partials 1053 1130 +77 ```
floreal (Migrated from github.com) reviewed 7 months ago
floreal (Migrated from github.com) left a comment

Maybe a selenium test would be nice.

Plume_migration_agent commented 7 months ago

Just a little alignment issue

				    .input_type("password")
Just a little alignment issue ```suggestion .input_type("password") ```
elegaanz (Migrated from github.com) approved these changes 7 months ago
elegaanz (Migrated from github.com) left a comment

Thanks, I’m merging it!

Reviewers

Plume_migration_agent approved these changes 7 months ago
The pull request has been merged as 506fe9955d.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.