Fixed: #713: Disply likes and boosts on post cards #744

已合併

floreal 將 1 次提交從 display-boost-and-likes-in-timelines 合併至 master

floreal 已留言 (已從 github.com 遷移)

This is a basic and simple way to display them. No interaction possible.

Alos, this patch is not optimised. as everytime a partial post_card is
called, Post::count_likes() and Post::count_reshares() are called
which means quite a few more quesies are sent to database unless diesel
uses some cache mechanisem.

A way to enhance this this would be to keep a count of likes and reshares
are kept in Post model / table.

This is a basic and simple way to display them. No interaction possible. Alos, this patch is not optimised. as everytime a partial post_card is called, `Post::count_likes()` and `Post::count_reshares()` are called which means quite a few more quesies are sent to database unless diesel uses some cache mechanisem. A way to enhance this this would be to keep a count of likes and reshares are kept in Post model / table.

floreal 已留言 (已從 github.com 遷移)

On dark theme:

On Light theme:

On dark theme: ![image](https://user-images.githubusercontent.com/386442/79052773-12495f80-7c39-11ea-8930-5cb96be67065.png) On Light theme: ![image](https://user-images.githubusercontent.com/386442/79052899-cc40cb80-7c39-11ea-8e80-95a7fe73eee5.png)

elegaanz 已留言 (已從 github.com 遷移)

Thanks for the PR.

I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help?

And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.

Thanks for the PR. I'm not 100% about the presentation, these counters looks too big and in the middle of the card to me, like if they were the most important information here. Maybe moving on the same line as the author/blog/date would help? And for the like/share counter cache on Post, feel free to implement it if you want, but this PR can probably be merged as it is. I don't know if Diesel does caching, but Postgres and SQlite certainly do, so it should be fine.

floreal 已留言 (已從 github.com 遷移)

Ok, how about that?

On larger cards:

@elegaanz is it ok with you ?

Ok, how about that? ![image](https://user-images.githubusercontent.com/386442/79077054-ae896a00-7cfe-11ea-85cc-9aa6e3a5a774.png) ![image](https://user-images.githubusercontent.com/386442/79077076-dc6eae80-7cfe-11ea-989d-9ea6eae52ba9.png) On larger cards: ![image](https://user-images.githubusercontent.com/386442/79077080-edb7bb00-7cfe-11ea-92b3-6179ad230a4f.png) @elegaanz is it ok with you ?

elegaanz (已從 github.com 遷移) 核可了這些變更

elegaanz (已從 github.com 遷移) 留下了回應

Yes, it looks great! Thank you

kiwii 在提交中關聯了這個問題

Fixed: #713: Disply likes and boosts on post cards (#744) This is a basic and simple way to display them. No interaction possible. Alos, this patch is not optimised. as everytime a partial post_card is called, `Post::count_likes()` and `Post::count_reshares()` are called which means quite a few more quesies are sent to database unless diesel uses some cache mechanisem. A way to enhance this this would be to keep a count of likes and reshares are kept in Post model / table.

審核者

此合併請求已被合併為 4e43c676b4。

您也可以查看命令列指南。

第一步：

在您的儲存庫中切換到新分支並測試變更。

git checkout -b display-boost-and-likes-in-timelines master

git pull origin display-boost-and-likes-in-timelines

第二步：

合併變更並更新到 Forgejo。

git checkout master

git merge --no-ff display-boost-and-likes-in-timelines

git push origin master

登入才能加入這對話。

沒有審核者

未選擇里程碑

沒有負責人

1 參與者

通知

截止日期

截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

載入中…

尚未有任何內容

標籤 里程碑

Fixed: #713: Disply likes and boosts on post cards #744

審核者

第一步：

第二步：

標籤里程碑