This patch fixes #701 .

The issue occurs because form value of email is empty string "" when user selects “Default theme” and it is set as preferred theme name. There’s no theme named "", so any theme is not applied. By setting NULL to users.preferred_theme when “Default theme” is selected, instance theme is used as the user’s preferred theme.

I used Diesel’s #[changeset_options(treat_none_as_null="true")] attribute on User model. This may not be preferred but save_changes doesn’t have option to set NULL sometimes and keep current value otherwise(See http://diesel.rs/guides/all-about-updates/ . It says “Diesel doesn’t currently provide a way to explicitly assign a field to its default value”). This is the reason why I used that attribute, but it may have too wide inpact. Could you consider?

Codecov Report

Merging #746 into master will not change coverage by %.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   39.00%   39.00%           
=======================================
  Files          73       73           
  Lines        9699     9699           
  Branches     2229     2229           
=======================================
  Hits         3783     3783           
- Misses       4754     4787   +33     
+ Partials     1162     1129   -33

elegaanz (Migrated from github.com) reviewed 7 months ago

I did a quick check to see if it could impact something else, but it looks like it is safe. Thanks for contributing!

elegaanz (Migrated from github.com) approved these changes 7 months ago

Woops, forgot to approve

Thank you for merging!

Sadly a new user of mine still just ran into missing CSS on 0.5.0 :(

@verymilan Can you re-save configuration again, please?

I am not sure what you mean, but as usual, i have made them selecting a theme and save, which was fixing their issue as always

Sorry for my poor English. What I did mean is...

Can you have your users select “Default theme” and save it? It might be fix the issue?

Under the hood, their current theme is saved as empty string "" but re-saving theme makes it NULL. And then default theme is applied.

Yes, i know, and this is how we did it - i was just ~expecting~ assuming that this workaround wasn’t needed anymore.

Ah, sorry, I missed your point.

i was just ~expecting~ assuming that this workaround wasn’t needed anymore.

Yes, your realization is correct.

kiwii referenced this issue from a commit 3 months ago

Fix #701 Preferable default theme (#746) * Make it possible to update users.preferred_theme to NULL * Make preferred them null when 'Default theme' is selected * Run cargo fmt

Reviewers

Plume_migration_agent approved these changes 7 months ago

The pull request has been merged as b834d1c282.

Plume_migration_agent

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#746 Fix #701 Preferable default theme

Codecov Report

Reviewers