#768 Make database connections configurable by environment variables

Merged
KitaitiMakoto merged 4 commits from db-conns-conf into master 6 months ago
KitaitiMakoto commented 6 months ago (Migrated from github.com)

so that we can tune performance.

so that we can tune performance.
codecov[bot] commented 6 months ago (Migrated from github.com)
Owner

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migrated from github.com) reviewed 6 months ago
elegaanz (Migrated from github.com) left a comment

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Plume_migration_agent commented 6 months ago

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migrated from github.com) reviewed 6 months ago
Plume_migration_agent commented 6 months ago

Good catch! There’s no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migrated from github.com) reviewed 6 months ago
elegaanz (Migrated from github.com) approved these changes 6 months ago
elegaanz (Migrated from github.com) left a comment

Great!

KitaitiMakoto commented 6 months ago (Migrated from github.com)
Owner

Thank you for the merge.

Thank you for the merge.

Reviewers

Plume_migration_agent approved these changes 6 months ago
The pull request has been merged as 3be842c653.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.