Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1

so that we can tune performance.

elegaanz (Migrated from github.com) reviewed 6 months ago

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

plume-models/src/config.rs

Plume_migration_agent commented 6 months ago

Is there a reason for panicking in one case and silently failing in the other?

KitaitiMakoto (Migrated from github.com) reviewed 6 months ago

Good catch! There’s no reason why. I will rewrite this and push it.

Done.

elegaanz (Migrated from github.com) approved these changes 6 months ago

Great!

Thank you for the merge.

kiwii referenced this issue from a commit 3 months ago

Make database connections configurable by environment variables (#768) * Make env DB_MAX_SIZE and DB_MIN_IDLE recognizable * Make database max size and minimum idle configurable * Restore file permission * Fail fast

Reviewers

Plume_migration_agent approved these changes 6 months ago

The pull request has been merged as 3be842c653.

#768 Make database connections configurable by environment variables

Codecov Report

Reviewers