Plume
/
Plume
8
16
Fork 22
Código Incidencias 174 Pull Requests 8 Lanzamientos 8 Wiki Actividad

Etiquetas Hitos

Make database connections configurable by environment variables #768

Fusionado
KitaitiMakoto fusionados 4 commits de db-conns-conf en master hace 4 años
Conversación 2 Commits 4 Archivos modificados 2
KitaitiMakoto comentado hace 4 años (Migrado desde github.com)

so that we can tune performance.

so that we can tune performance.
codecov[bot] comentado hace 4 años (Migrado desde github.com)

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migrado desde github.com) revisado hace 4 años
elegaanz (Migrado desde github.com) dejó un comentario

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
plume-models/src/config.rs
elegaanz (Migrado desde github.com) comentado hace 4 años

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migrado desde github.com) revisado hace 4 años
plume-models/src/config.rs
KitaitiMakoto (Migrado desde github.com) comentado hace 4 años

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migrado desde github.com) revisado hace 4 años
plume-models/src/config.rs
KitaitiMakoto (Migrado desde github.com) comentado hace 4 años

Done.

Done.
elegaanz (Migrado desde github.com) aprobado estos cambios hace 4 años
elegaanz (Migrado desde github.com) dejó un comentario

Great!

Great!
KitaitiMakoto comentado hace 4 años (Migrado desde github.com)

Thank you for the merge.

Thank you for the merge.

Revisores

elegaanz
El Pull Request se ha fusionado como 3be842c653.
También puede ver instrucciones de línea de comandos.

Paso 1:

Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.
git checkout -b db-conns-conf master
git pull origin db-conns-conf

Paso 2:

Combine los cambios y actualice en Forgejo.
git checkout master
git merge --no-ff db-conns-conf
git push origin master
Inicie sesión para unirse a esta conversación.
Revisores
Solicitar revisión
No hay revisores
elegaanz
Etiquetas
Aplicar etiquetas
Limpiar etiquetas   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Sin etiquetas
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Fijar hito
Limpiar Milestone
No hay elementos
Sin Milestone
Asignados
Asignar usuarios
Limpiar asignados
No asignados
1 participantes
Notificaciones
Fecha de vencimiento
La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#768
Escribir Vista previa
Cargando…
Cancelar
Guardar
Aún no existe contenido.
Eliminar la rama con el nombre 'db-conns-conf'

Eliminar una rama es permanente. NO PUEDE deshacerse. ¿Continuar?

No
Sí