Make database connections configurable by environment variables #768

Yhdistetty

KitaitiMakoto yhdistetty 4 committia lähteestä db-conns-conf kohteeseen master

KitaitiMakoto kommentoi (Migrated from github.com)

so that we can tune performance.

codecov[bot] kommentoi (Migrated from github.com)

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```

elegaanz (Migrated from github.com) reviewed

elegaanz (Migrated from github.com) jätti kommentin

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

plume-models/src/config.rs

elegaanz (Migrated from github.com) kommentoi

Is there a reason for panicking in one case and silently failing in the other?

KitaitiMakoto (Migrated from github.com) reviewed

plume-models/src/config.rs

KitaitiMakoto (Migrated from github.com) kommentoi

Good catch! There's no reason why. I will rewrite this and push it.

KitaitiMakoto (Migrated from github.com) reviewed

plume-models/src/config.rs

KitaitiMakoto (Migrated from github.com) kommentoi

Done.

elegaanz (Migrated from github.com) hyväksyi nämä muutokset

elegaanz (Migrated from github.com) jätti kommentin

Great!

KitaitiMakoto kommentoi (Migrated from github.com)

Thank you for the merge.

kiwii viittasi tähän ongelmaan commitissa

Make database connections configurable by environment variables (#768) * Make env DB_MAX_SIZE and DB_MIN_IDLE recognizable * Make database max size and minimum idle configurable * Restore file permission * Fail fast

Reviewers

The pull request has been merged as 3be842c653.

You can also view command line instructions.

Vaihe 1:

From your project repository, check out a new branch and test the changes.

git checkout -b db-conns-conf master

git pull origin db-conns-conf

Vaihe 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff db-conns-conf

git push origin master

No reviewers

Ei merkkipaalua

Ei käsittelijää

1 osallistujaa

Ilmoitukset

Määräpäivä

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Ladataan…

Sisältöä ei vielä ole.

Tunnisteet Merkkipaalut

Make database connections configurable by environment variables #768

Codecov Report

Reviewers

Vaihe 1:

Vaihe 2: