Plume/Plume
9
18
Forkkaa 24
Koodi Ongelmat 177 Vetopyynnöt 8 Julkaisut 8 Wiki Toiminta

Make database connections configurable by environment variables #768

Yhdistetty
KitaitiMakoto yhdistetty 4 committia lähteestä db-conns-conf kohteeseen master 2020-05-06 17:28:00 +00:00
Keskustelu 2 Commitit 4 Muuttuneet tiedostot 2 +16 -3
KitaitiMakoto kommentoi 2020-05-05 06:32:32 +00:00 (Migrated from github.com)
Kopioi linkki

so that we can tune performance.

so that we can tune performance.
codecov[bot] kommentoi 2020-05-05 06:59:18 +00:00 (Migrated from github.com)
Kopioi linkki

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migrated from github.com) reviewed 2020-05-05 21:45:21 +00:00
elegaanz (Migrated from github.com) jätti kommentin
Kopioi linkki

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
plume-models/src/config.rs
elegaanz (Migrated from github.com) kommentoi 2020-05-05 21:43:59 +00:00
Kopioi linkki

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migrated from github.com) reviewed 2020-05-05 22:09:38 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migrated from github.com) kommentoi 2020-05-05 22:09:38 +00:00
Kopioi linkki

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migrated from github.com) reviewed 2020-05-05 22:11:41 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migrated from github.com) kommentoi 2020-05-05 22:11:41 +00:00
Kopioi linkki

Done.

Done.
elegaanz (Migrated from github.com) hyväksyi nämä muutokset 2020-05-06 17:27:53 +00:00
elegaanz (Migrated from github.com) jätti kommentin
Kopioi linkki

Great!

Great!
KitaitiMakoto kommentoi 2020-05-06 20:01:59 +00:00 (Migrated from github.com)
Kopioi linkki

Thank you for the merge.

Thank you for the merge.
Kirjaudu sisään liittyäksesi keskusteluun.
Reviewers
No reviewers
elegaanz
Tunnisteet
Tyhjennä tunnisteet   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Ei tunnisteita
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Merkkipaalu
Tyhjennä merkkipaalu
Ei kohteita
Ei merkkipaalua
Projektit
Clear projects
Ei kohteita
Ei projektia
Käsittelijä
Tyhjennä käsittelijä
Ei käsittelijää
1 osallistuja
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

Määräpäivää ei ole asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Viittaus: Plume/Plume#768
Ei kuvausta.
Poista haara "db-conns-conf"

Haaran poistaminen on pysyvä toimenpide. Vaikka poistettu haara voi jäädä olemaan lyhyeksi ajaksi, ennen kuin todellisesti poistetaan, poistoa EI VOI perua useimmiten. Jatketaanko?