Plume/Plume
9
18
Bifurcation 24
Code Tickets 177 Demandes d'ajout 8 Publications 8 Wiki Activité

Make database connections configurable by environment variables #768

Fusionnée
KitaitiMakoto a fusionné 4 révision(s) à partir de db-conns-conf vers master 2020-05-06 17:28:00 +00:00
Discussion 2 Révisions 4 Fichiers Modifiés 2 +16 -3
KitaitiMakoto a commenté 2020-05-05 06:32:32 +00:00. (Migré de github.com)
Copier le lien

so that we can tune performance.

so that we can tune performance.
codecov[bot] a commenté 2020-05-05 06:59:18 +00:00. (Migré de github.com)
Copier le lien

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migré de github.com) a évalué cette demande d’ajout 2020-05-05 21:45:21 +00:00
elegaanz (Migré de github.com) a laissé un commentaire
Copier le lien

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
plume-models/src/config.rs
elegaanz (Migré de github.com) a commenté 2020-05-05 21:43:59 +00:00.
Copier le lien

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migré de github.com) a évalué cette demande d’ajout 2020-05-05 22:09:38 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migré de github.com) a commenté 2020-05-05 22:09:38 +00:00.
Copier le lien

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migré de github.com) a évalué cette demande d’ajout 2020-05-05 22:11:41 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migré de github.com) a commenté 2020-05-05 22:11:41 +00:00.
Copier le lien

Done.

Done.
elegaanz (Migré de github.com) a approuvé ces modifications 2020-05-06 17:27:53 +00:00
elegaanz (Migré de github.com) a laissé un commentaire
Copier le lien

Great!

Great!
KitaitiMakoto a commenté 2020-05-06 20:01:59 +00:00. (Migré de github.com)
Copier le lien

Thank you for the merge.

Thank you for the merge.
Connectez-vous pour rejoindre cette conversation.
Évaluateurs
Sans évaluateur
elegaanz
Labels
Effacer les labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Sans labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Jalon
Effacer le jalon
Pas d'élément
Sans jalon
Projets
Effacer les projets
Pas d'élément
Sans projet
Assignés
Supprimer les affectations
Sans assignation
1 participant
Notifications
Échéance
La date d’échéance est invalide ou hors plage. Veuillez utiliser le format "aaaa-mm-dd".

Aucune échéance n'a été définie.

Dépendances

Aucune dépendance définie.

Référence : Plume/Plume#768
Sans contenu.
Supprimer la branche "db-conns-conf"

La suppression d’une branche est permanente. Bien qu’une branche supprimée puisse temporairement subsister, elle NE PEUT PAS être facilement restaurée. Continuer ?