#768 Make database connections configurable by environment variables

Unito
KitaitiMakoto ha unito 4 commit da db-conns-conf a master 8 mesi fa
KitaitiMakoto 8 mesi fa ha commentato (Migrato da github.com)

so that we can tune performance.

so that we can tune performance.
codecov[bot] 8 mesi fa ha commentato (Migrato da github.com)
Proprietario

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migrato da github.com) revisionato 8 mesi fa
elegaanz (Migrato da github.com) lascia un commento

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Plume_migration_agent 8 mesi fa ha commentato

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migrato da github.com) revisionato 8 mesi fa
Plume_migration_agent 8 mesi fa ha commentato

Good catch! There’s no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migrato da github.com) revisionato 8 mesi fa
elegaanz (Migrato da github.com) hanno approvato queste modifiche 8 mesi fa
elegaanz (Migrato da github.com) lascia un commento

Great!

KitaitiMakoto 8 mesi fa ha commentato (Migrato da github.com)
Proprietario

Thank you for the merge.

Thank you for the merge.

Revisori

Plume_migration_agent hanno approvato queste modifiche 8 mesi fa
La pull request è stata unita come 3be842c653.
Effettua l'accesso per partecipare alla conversazione.
Nessun revisore
Nessuna milestone
Nessuna assegnatario
1 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

Caricamento…
Non ci sono ancora contenuti.