Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1

so that we can tune performance.

elegaanz (Migrato da github.com) revisionato 8 mesi fa

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

plume-models/src/config.rs

Plume_migration_agent 8 mesi fa ha commentato

Is there a reason for panicking in one case and silently failing in the other?

KitaitiMakoto (Migrato da github.com) revisionato 8 mesi fa

Good catch! There’s no reason why. I will rewrite this and push it.

Done.

elegaanz (Migrato da github.com) hanno approvato queste modifiche 8 mesi fa

Great!

Thank you for the merge.

kiwii ha fatto riferimento a questa issue dal commit 5 mesi fa

Make database connections configurable by environment variables (#768) * Make env DB_MAX_SIZE and DB_MIN_IDLE recognizable * Make database max size and minimum idle configurable * Restore file permission * Fail fast

Revisori

Plume_migration_agent hanno approvato queste modifiche 8 mesi fa

La pull request è stata unita come 3be842c653.

Effettua l'accesso per partecipare alla conversazione.

#768 Make database connections configurable by environment variables

Codecov Report

Revisori