Make database connections configurable by environment variables #768

マージ済み
KitaitiMakoto が 4 個のコミットを db-conns-conf から master へマージ 2020-05-06 17:28:00 +00:00
KitaitiMakoto がコメント 2020-05-05 06:32:32 +00:00 (github.comから移行)

so that we can tune performance.

so that we can tune performance.
codecov[bot] がコメント 2020-05-05 06:59:18 +00:00 (github.comから移行)

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (github.comから移行) がレビュー 2020-05-05 21:45:21 +00:00
elegaanz (github.comから移行) がコメント

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
elegaanz (github.comから移行) がコメント 2020-05-05 21:43:59 +00:00

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (github.comから移行) がレビュー 2020-05-05 22:09:38 +00:00
KitaitiMakoto (github.comから移行) がコメント 2020-05-05 22:09:38 +00:00

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (github.comから移行) がレビュー 2020-05-05 22:11:41 +00:00
KitaitiMakoto (github.comから移行) がコメント 2020-05-05 22:11:41 +00:00

Done.

Done.
elegaanz (github.comから移行) が変更を承認 2020-05-06 17:27:53 +00:00
elegaanz (github.comから移行) がコメント

Great!

Great!
KitaitiMakoto がコメント 2020-05-06 20:01:59 +00:00 (github.comから移行)

Thank you for the merge.

Thank you for the merge.
サインインしてこの会話に参加。
レビューアなし
マイルストーンなし
プロジェクトなし
担当者なし
1 人の参加者
通知
期日
期日が正しくないか範囲を超えています。 "yyyy-mm-dd" の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#768
説明はありません。