#768 Make database connections configurable by environment variables

マージ済み
KitaitiMakoto が 4 個のコミットを db-conns-conf から master へマージ 8ヶ月前
KitaitiMakoto 8ヶ月前 にコメント (github.comから移行)

so that we can tune performance.

so that we can tune performance.
codecov[bot]8ヶ月前 にコメント (github.comから移行)
オーナー

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (github.comから移行) がレビュー 8ヶ月前
elegaanz (github.comから移行) がコメント

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Plume_migration_agent8ヶ月前 にコメント

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (github.comから移行) がレビュー 8ヶ月前
Plume_migration_agent8ヶ月前 にコメント

Good catch! There’s no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (github.comから移行) がレビュー 8ヶ月前
elegaanz (github.comから移行) が変更を承認 8ヶ月前
elegaanz (github.comから移行) がコメント

Great!

KitaitiMakoto8ヶ月前 にコメント (github.comから移行)
オーナー

Thank you for the merge.

Thank you for the merge.

レビューア

Plume_migration_agent が変更を承認 8ヶ月前
プルリクエストは 3be842c653 でマージされています。
サインインしてこの会話に参加。
レビューアなし
マイルストーンなし
担当者なし
1 人の参加者
通知
期日

期日は未設定です。

依存関係

このプルリクエストに依存関係はありません。

読み込み中…
まだ内容がありません