Plume/Plume
9
18
포크 24
코드 이슈 177 풀 리퀘스트 8 릴리즈 8 위키 활동

Make database connections configurable by environment variables #768

병합됨
KitaitiMakoto 님이 db-conns-conf 에서 master 로 4 커밋을 2020-05-06 17:28:00 +00:00 병합함
대화 2 커밋 4 파일 변경 2 +16 -3
KitaitiMakoto 코멘트함, 2020-05-05 06:32:32 +00:00 (Migrated from github.com)
Copy link

so that we can tune performance.

so that we can tune performance.
codecov[bot] 코멘트함, 2020-05-05 06:59:18 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migrated from github.com) 검토됨 2020-05-05 21:45:21 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
plume-models/src/config.rs
elegaanz (Migrated from github.com) 코멘트함, 2020-05-05 21:43:59 +00:00
Copy link

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migrated from github.com) 검토됨 2020-05-05 22:09:38 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migrated from github.com) 코멘트함, 2020-05-05 22:09:38 +00:00
Copy link

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migrated from github.com) 검토됨 2020-05-05 22:11:41 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migrated from github.com) 코멘트함, 2020-05-05 22:11:41 +00:00
Copy link

Done.

Done.
elegaanz (Migrated from github.com) 이 변경사항을 승인함 2020-05-06 17:27:53 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Great!

Great!
KitaitiMakoto 코멘트함, 2020-05-06 20:01:59 +00:00 (Migrated from github.com)
Copy link

Thank you for the merge.

Thank you for the merge.
로그인하여 이 대화에 참여하세요.
리뷰어
No reviewers
elegaanz
레이블
레이블 초기화   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

레이블 없음
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
마일스톤
마일스톤 초기화
No items
마일스톤 없음
Projects
Clear projects
No items
프로젝트 없음
담당자
담당자 초기화
담당자 없음
참가자 1명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. "yyyy-mm-dd"형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

전제조건

전제조건이 설정되지 않았습니다.

Reference: Plume/Plume#768
No description provided.
Delete branch "db-conns-conf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?