Plume/Plume
9
18
Atzarojums 24
Kods Pieteikumi 177 Izmaiņu pieprasījumi 8 Laidieni 8 Vikivietne Notikumi

Make database connections configurable by environment variables #768

Apvienots
KitaitiMakoto Iekļāva 4 iesūtījumus no db-conns-conf zarā master 2020-05-06 17:28:00 +00:00
Saruna 2 Iesūtījumi 4 Izmainītās datnes 2 +16 -3
KitaitiMakoto pievienoja piebildi 2020-05-05 06:32:32 +00:00 (Pārcelta no github.com)
Ievietot saiti starpliktuvē

so that we can tune performance.

so that we can tune performance.
codecov[bot] pievienoja piebildi 2020-05-05 06:59:18 +00:00 (Pārcelta no github.com)
Ievietot saiti starpliktuvē

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Pārcelta no github.com) izskatīja 2020-05-05 21:45:21 +00:00
elegaanz (Pārcelta no github.com) pievienoja piebildi
Ievietot saiti starpliktuvē

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
plume-models/src/config.rs
elegaanz (Pārcelta no github.com) pievienoja piebildi 2020-05-05 21:43:59 +00:00
Ievietot saiti starpliktuvē

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Pārcelta no github.com) izskatīja 2020-05-05 22:09:38 +00:00
plume-models/src/config.rs
KitaitiMakoto (Pārcelta no github.com) pievienoja piebildi 2020-05-05 22:09:38 +00:00
Ievietot saiti starpliktuvē

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Pārcelta no github.com) izskatīja 2020-05-05 22:11:41 +00:00
plume-models/src/config.rs
KitaitiMakoto (Pārcelta no github.com) pievienoja piebildi 2020-05-05 22:11:41 +00:00
Ievietot saiti starpliktuvē

Done.

Done.
elegaanz (Pārcelta no github.com) apstiprināja šīs izmaiņas 2020-05-06 17:27:53 +00:00
elegaanz (Pārcelta no github.com) pievienoja piebildi
Ievietot saiti starpliktuvē

Great!

Great!
KitaitiMakoto pievienoja piebildi 2020-05-06 20:01:59 +00:00 (Pārcelta no github.com)
Ievietot saiti starpliktuvē

Thank you for the merge.

Thank you for the merge.
Nepieciešams pieteikties, lai pievienotos šai sarunai.
Izskatītāji
Nav izskatītāju
elegaanz
Iezīmes
Notīrīt iezīmes   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Nav iezīmju
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Atskaites punkts
Notīrīt atskaites punktus
Nav neviena ieraksta
Nav atskaites punkta
Projekti
Notīrīt projektus
Nav neviena ieraksta
Nav projektu
Atbildīgie
Noņemt atbildīgo
Nav atbildīgo
1 dalībnieks
Paziņojumi
Izpildes datums
Izpildes datums nav derīgs vai tas ir ārpus datumu apgabala. Lūgums izmantot pierakstu "gggg-mm-dd".

Nav uzstādīts izpildes datums.

Atkarības

Nav atkarību.

Atsauce: Plume/Plume#768
Nav sniegts apraksts.
Izdzēst zaru "db-conns-conf"

Zara izdzēšana ir neatgriezeniska. Kaut arī izdzēstais zars neilgu laiku var turpināt pastāvēt, pirms tas patiešām tiek noņemts, to vairumā gadījumu NEVAR atsaukt. Turpināt?